[PATCH 1/2] qmicli: preparing for firmware download support

Aleksander Morgado aleksander at aleksander.es
Mon Aug 29 11:07:31 UTC 2016


On Mon, Aug 29, 2016 at 12:15 PM, Bjørn Mork <bjorn at mork.no> wrote:
> Aleksander Morgado <aleksander at aleksander.es> writes:
>> On 19/08/16 16:29, Bjørn Mork wrote:
>>
>>> +    { "dms-set-firmware-pref", 0, 0, G_OPTION_ARG_STRING, &set_firmware_pref_str,
>>> +      "Set firmware preference",
>>> +      "[(fwver),(config),(carrier)]"
>>> +    },
>>
>> Could we make it "--dms-set-firmware-preference"? That would align with
>> all the other long-format commands, which take full words, not just
>> prefixes.
>
> Yes, please make this consistent.  I'm just too lazy to write such long
> wrds.  Sorry about that
>


Pushed your patch and a follow up fixing this.

Cheers!

-- 
Aleksander
https://aleksander.es


More information about the libqmi-devel mailing list