WDS Bind Mux Port?
Daniele Palmas
dnlplm at gmail.com
Wed Feb 15 09:34:10 UTC 2017
Hi Bjørn and all,
2017-01-17 16:12 GMT+01:00 Bjørn Mork <bjorn at mork.no>:
> Daniele Palmas <dnlplm at gmail.com> writes:
>> 2017-01-12 14:53 GMT+01:00 Bjørn Mork <bjorn at mork.no>:
>>> Daniele Palmas <dnlplm at gmail.com> writes:
>>>
>>>> 2017-01-11 21:21 GMT+01:00 Bjørn Mork <bjorn at mork.no>:
>>>>
>>>> Thanks!! I'll try to take a look at this and, if possible, do some tests!
>>>
>>> I know I wasn't going to spend more time on this, but the attached
>>> "Doh!" fix showed up in the back of my head while I was sleeping. It
>>> saves you from testing how many netdes your system can handle before it
>>> slowly stops ;)
>>>
>>> Note that it still doesn't work. I'm doing something wrong when looking
>>> up the interfaces. But the lookup code should probably be made much more
>>> efficient than looping over a list anyway, since we'll do it for each
>>> packet received.
>>
>> I'm slowly taking a look and I'm not an expert, so please forgive me
>> if I say something silly.
>>
>> In qmimux_find_dev should netdev_for_each_lower_dev replaced by
>> something like netdev_for_each_upper_dev_rcu ?
>>
>> Similar fix also in the other parts (e.g. add_mux_show).
>
> Yes, that is probably correct. I have a vertigo issue with network
> device stacking ;)
>
attached my fixes to Bjørn's implementation to be applied on top of
Bjørn's patches, not sure if this is how they should be done, but
things seem to work properly since I'm now able to have two concurrent
data connections.
qmi_disconnect implementation is due to a problem when disconnecting
the device (or removing the kernel module) if a qmimux network
interface was still present.
Carlo is patching libqmi to add support at the userspace level and
will send the patches once available.
Daniele
>
> Bjørn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-qmi_wwan-mux-fixes.patch
Type: text/x-patch
Size: 2756 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/libqmi-devel/attachments/20170215/7229deaa/attachment.bin>
More information about the libqmi-devel
mailing list