[PATCH] qmi-network: Don't create invalid --wds-start-network when APN is not set

Adrian Bunk bunk at stusta.de
Mon Oct 1 13:53:31 UTC 2018


In 1.20.2 the warning for this was turned into an error.
---
 utils/qmi-network.in | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/utils/qmi-network.in b/utils/qmi-network.in
index bf7bed9..a9e5299 100755
--- a/utils/qmi-network.in
+++ b/utils/qmi-network.in
@@ -334,11 +334,13 @@ start_network ()
 
     setup_data_format
 
-    START_NETWORK_ARGS="apn='$APN'"
-    if [ -n "$APN_USER" ]; then
-        START_NETWORK_ARGS="${START_NETWORK_ARGS},username='$APN_USER'"
-        if [ -n "$APN_PASS" ]; then
-            START_NETWORK_ARGS="${START_NETWORK_ARGS},password='$APN_PASS'"
+    if [ -n "$APN" ]; then
+        START_NETWORK_ARGS="apn='$APN'"
+        if [ -n "$APN_USER" ]; then
+            START_NETWORK_ARGS="${START_NETWORK_ARGS},username='$APN_USER'"
+            if [ -n "$APN_PASS" ]; then
+                START_NETWORK_ARGS="${START_NETWORK_ARGS},password='$APN_PASS'"
+            fi
         fi
     fi
 
-- 
2.11.0



More information about the libqmi-devel mailing list