[PATCH] qmi-network: Don't create invalid --wds-start-network when APN is not set

[Aleksander Morgado]

On 10/1/18 3:53 PM, Adrian Bunk wrote:
> In 1.20.2 the warning for this was turned into an error.
> ---

Thanks, pushed to git master and the qmi-1-20 branch.

>  utils/qmi-network.in | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/utils/qmi-network.in b/utils/qmi-network.in
> index bf7bed9..a9e5299 100755
> --- a/utils/qmi-network.in
> +++ b/utils/qmi-network.in
> @@ -334,11 +334,13 @@ start_network ()
>  
>      setup_data_format
>  
> -    START_NETWORK_ARGS="apn='$APN'"
> -    if [ -n "$APN_USER" ]; then
> -        START_NETWORK_ARGS="${START_NETWORK_ARGS},username='$APN_USER'"
> -        if [ -n "$APN_PASS" ]; then
> -            START_NETWORK_ARGS="${START_NETWORK_ARGS},password='$APN_PASS'"
> +    if [ -n "$APN" ]; then
> +        START_NETWORK_ARGS="apn='$APN'"
> +        if [ -n "$APN_USER" ]; then
> +            START_NETWORK_ARGS="${START_NETWORK_ARGS},username='$APN_USER'"
> +            if [ -n "$APN_PASS" ]; then
> +                START_NETWORK_ARGS="${START_NETWORK_ARGS},password='$APN_PASS'"
> +            fi
>          fi
>      fi
>  
> 


-- 
Aleksander
https://aleksander.es