[review] EM75xx firmware update using qmi-firmware-update

[Reinhard Speyerer]

On Mon, Jun 24, 2019 at 11:47:13PM +0200, Aleksander Morgado wrote:
> Hey Bjørn & all
> 
> I've pushed a new MR to gitlab that includes support for the EM75xx
> firmware update process, using the Sahara/Firehose protocols:
> https://gitlab.freedesktop.org/mobile-broadband/libqmi/merge_requests/40
> 
> I've uploaded a reference example log to the MR as well. Comments and
> tests (with --verbose) welcome!
> 
> P.S.: I have really done tons of failed attempts before getting the
> process more or less right and consistent, and my one and only EM7565
> is still alive.

Hi Aleksander,

thank you for working on this. After applying this patch

diff -U1 -p src/qmi-firmware-update/qfu-sahara-device.c{.~1~,}
--- src/qmi-firmware-update/qfu-sahara-device.c.~1~	2019-06-27 15:05:49.956544390 +0200
+++ src/qmi-firmware-update/qfu-sahara-device.c	2019-06-27 15:53:51.544031910 +0200
@@ -1102,3 +1102,3 @@ sahara_device_run_protocol_step (QfuSaha
     SaharaProtocolStep  next_step = SAHARA_PROTOCOL_STEP_UNKNOWN;
-    gsize               reqlen;
+    gsize               reqlen = 0;
     gssize              rsplen;

to fix compilation with -Wsometimes-uninitialized I could successfully
update an EM7565 from

   original firmware revision was:
      SWI9X50C_01.08.04.00 dbb5d0 jenkins 2018/08/21 21:40:11
   original running firmware details:
      Model: EM7565
      Boot version: SWI9X50C_01.08.04.00
      AMSS version: SWI9X50C_01.08.04.00
      SKU ID: 1104207
      Carrier ID: 1
      Config version: 002.011_000
   original firmware preference details:
      image 'modem': unique id '002.011_000', build id '01.08.04.00_GENERIC'
      image 'pri': unique id '002.011_000', build id '01.08.04.00_GENERIC'

to the new firmware

   new firmware revision is:
      SWI9X50C_01.09.04.00 6d3218 jenkins 2019/02/26 20:33:22
   new running firmware details:
      Model: EM7565
      Boot version: SWI9X50C_01.09.04.00
      AMSS version: SWI9X50C_01.09.04.00
      SKU ID: 1104207
      Carrier ID: 1
      Config version: 002.019_000
   new firmware preference details:
      image 'modem': unique id '002.019_000', build id '01.09.04.00_GENERIC'
      image 'pri': unique id '002.019_000', build id '01.09.04.00_GENERIC'

announced here
https://forum.sierrawireless.com/t/em7565-aggregating-b1-b3-does-not-work-as-expected/13861/43
yesterday.

Regards,
Reinhard