Implicit master interface setup when creating new links?

Bjørn Mork bjorn at mork.no
Tue Feb 16 07:37:55 UTC 2021


Aleksander Morgado <aleksander at aleksander.es> writes:

> Ok, I've just realized this cannot be done. Creating new links
> *requires* the interface to be dow

Ouch. Never noticed that before.  Tells you how much I've been using
this.... Doesn't look quite right to me.

I believe the part we wanted to protect is the modification of the
master interface.  But there is no reason we couldn't add and/or delete
links 2+ with master running.  Actually, I am not sure there is any
reason at all here?  This seems to be just accidentally copied from the
raw-ip code.  But there we change the header_ops etc on master, so it
makes sense. We don't do anything like that for muxing - the master is
left as-is.  So why not just add/del links on the fly without taking
down master?

A bit late to fix that now, I guess.  At least for your immediate needs.
But I believe we could loosen up the restrictions without breaking any
userspace expectations. So it's tempting to fix it in any case.  If
anyone cares?



Bjørn


More information about the libqmi-devel mailing list