[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #14 from JoNi <j.nitschke+tdfbz at ok.de> ---
(In reply to Commit Notification from comment #13)
> Julien Nabet committed a patch related to this issue.
> It has been pushed to "master":
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=8c0cc5cd7befffc6e8e6361ba67807a799cc997f
> 
> Related tdf#105500: leaks in PaletteManager and SvxColorToolBoxControl

I doubt this patch does anything.
~SvxColorToolBoxControl destructs all it's members including m_xPaletteManager.
The unique_ptr<PaletteManager> destructor calls destructor of the
PaletteManager object.
~PaletteManager destructs all it's members too. This includes the vector
m_Palettes. A vector destructor calls the destructor for all objects it holds
(clear() does the same). So finally the unique_ptr<Pallette> destructors
release all the Palette objects.
We don't have to worry about reset, clear, delete or anything.

That said, I don't see any obvious leaks. But I got no idea how to interpret 
attachment 135607, looks like it's only listing allocations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170817/c2668872/attachment-0001.html>