[Libreoffice-bugs] [Bug 108919] Assertion failed when inserting rectangle shape in spreadsheet

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=108919

Stephan Bergmann <sbergman at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oliver.specht at cib.de

--- Comment #4 from Stephan Bergmann <sbergman at redhat.com> ---
That's interesting.  When doing
<https://cgit.freedesktop.org/libreoffice/core/commit/?id=13bb5a4b09f5b2ad19dad1b55f45d0fe2b2fb908>
"Make SfxItemSet ranges correct by construction" I naively assumed that an
SfxItemSet's ranges would never include a WID=0, and that therefore the
constructor with a single range,

> SfxItemSet( SfxItemPool&, sal_uInt16 nWhich1, sal_uInt16 nWhich2 );

should never be called with nWhich1=0 (just as for the multi-range constructor

> SfxItemSet( SfxItemPool&, int nWh1, int nWh2, int nNull, ... );

an argument of 0 signals end-of-ranges).

However, ever since
<https://cgit.freedesktop.org/libreoffice/core/commit/?id=71b45e713f2426a70538e2620ee21fa18d82cc89>
"INTEGRATION: CWS pchfix04", FuConstCustomShape::SetAttributes
(sc/source/ui/drawfunc/fuconcustomshape.cxx) creates an SvxAdjustItem with
WID=0, which is then passed into the SfxItemSet constructor as seen in the
backtrace in attachment 134466.

The other changes from that CWS pchfix04 (see "git log --patch --grep='#i73604#
 eeitemid.hxx removed'" and "git log --patch --grep='#i73604# usage of
ITEMID_\* removed'") create SvxAdjustItem instances with RES_PARATR_ADJUST or
EE_PARA_JUST, it appears to be just this one exception with an explicit WID=0.

It is still unclear to me whether SfxItemSet instances containing WID=0 should
e allowed, or whether the change in sc/source/ui/drawfunc/fuconcustomshape.cxx
(done by Oliver) was wrong.  Oliver, any thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170704/45fe1308/attachment.html>