[Libreoffice-bugs] [Bug 107975] CRASH: Crash after undo operation (BigPtrArray::Index2Block( unsigned long)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=107975

Michael Stahl <mstahl at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
           See Also|                            |https://bz.apache.org/ooo/s
                   |                            |how_bug.cgi?id=97570
         Resolution|---                         |FIXED
           Assignee|libreoffice-bugs at lists.free |mstahl at redhat.com
                   |desktop.org                 |

--- Comment #9 from Michael Stahl <mstahl at redhat.com> ---

the commit in comment #7 is a good idea but unfortunately incomplete;
there are other places than the one changed there that need to agree
as to whether flys in a selection are deleted or not.

this includes Undo as in this report and OOo issue 97570 (Insert File
instead of Paste) which was incidentally re-introduced by this commit,
as well as redlining.

the Undo currently has difficulties distinguishing between flys
that were already there vs. flys that were inserted by the Paste,
so if it deletes too many flys all the nodes-indexes stored
in Undo objects are off and can cause out-of-bounds indexing.

there is some mechanism in shellio.cxx to track inserted flys;
i forgot if that is used during Paste or not...

unfortunately i'm short on time to investigate how this should work,
so i'll just revert the commit for now, shouldn't crash any more at least.

fixed on master

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170719/202f9607/attachment.html>