[Libreoffice-bugs] [Bug 100233] Wrong Windows version reported in the About window in Windows 10

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=100233

--- Comment #13 from V Stuart Foote <vstuart.foote at utsa.edu> ---
No, we seem to have an implementation problem here with the Windows version
idents [1]. Microsoft deprecated the GetVersionEx() call in current SDKs, but
we've not fully adjusted.

Michael S. tests the generic Windows > Vista with [2][3], and we make the OS
Version query here:
http://opengrok.libreoffice.org/xref/core/vcl/source/app/svapp.cxx#1173
http://opengrok.libreoffice.org/xref/core/vcl/win/app/salinst.cxx#1012

Unfortunately, IIUC since our builds remain targeted at Windows XP and do not
manifest for later releases, I think the version returns major 6 minor 2.

Seems that to identify Windows details we probably need to pull major and minor
version ID from OSVERSIONINFO [4], similar to what is being done for OpenGL
support. 
http://opengrok.libreoffice.org/xref/core/vcl/opengl/win/WinDeviceInfo.cxx#185

For the Help -> About dialog if we want to provide more than major minor and
want to include the build version--we could pull from the OSVERSIONINFOEX
struct [5] rather than OSVERSIONINFO.

Also, there are some legacy calls that probably need to be cleaned up:
http://opengrok.libreoffice.org/xref/core/vcl/win/app/salinst.cxx?a=true#415
for example where we've hard coded only through Windows 7--with no handling of
8, 8.1 or 10.

=-refs-=
[1] https://msdn.microsoft.com/en-us/library/ms724832(v=vs.85).aspx

[2] https://msdn.microsoft.com/en-us/library/ms724451(v=vs.85).aspx
[3] https://gerrit.libreoffice.org/#/c/14020/

[4] https://msdn.microsoft.com/en-us/library/ms724834(VS.85).aspx

[5] https://msdn.microsoft.com/en-us/library/ms724833(v=vs.85).aspx

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170626/5c42b754/attachment-0001.html>