[Libreoffice-bugs] [Bug 122171] LibreOffice remains open in background if it's closed while XML filter settings dialog is open

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=122171

Samuel Mehrbrodt (CIB) <s.mehrbrodt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |difficultyBeginner,
                   |                            |easyHack, skillCpp,
                   |                            |topicDebug, topicUI

--- Comment #3 from Samuel Mehrbrodt (CIB) <s.mehrbrodt at gmail.com> ---
(In reply to Caolán McNamara from comment #1)
> I think bug#102288 causes this problem. This dialog throws a CloseVeto when
> it has a modal dialog open, but that no longer does what it used to do,
> which was to leave a toplevel window open.

Yes this seems to be caused by my change how TerminationVetoException is
handled.
So instead of throwing a TerminationVetoException, we need to throw a
CloseVetoException here (that would prevent windows from closing).

And we need to listen to XCloseListener::queryClosing instead of
XTerminateListener::queryTermination.

The file is filter/source/xsltdialog/xmlfilterdialogcomponent.cxx .

This change should be quite easy, making an Easy Hack out of it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20181219/56395bf7/attachment.html>