[Libreoffice-bugs] [Bug 115573] EDITING: Table loses formatting when inserting a new row in a table

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=115573

--- Comment #36 from Jim Raykowski <raykowj at gmail.com> ---
(In reply to Aron Budea from comment #35)
> Jim, in [1] the conclusion is that the patches for bug 108227 and bug 107555
> need to be reverted for now, can you please give an update on that?
> 
> [1] https://gerrit.libreoffice.org/#/c/49831/

Hi Aron, 
Yes these patches should be reverted for now. I believe both are good ideas but
need to wait until autoformat and user direct formatting of tables can be made
to work well together. 

I have thought of two ways this can be accomplished and have had some success
with both: 

1. When direct formatting is made to a table then the table's autoformat style
is no longer used. This results in no table style highlighted in the sidebar
styles table styles panel after a direct format is made. Autoformatting is no
longer applied to the table afer row/column additions/deletions so that direct
formatting is preserved.

2. The table retains the autoformat style for table boxes (cells) that do not
have direct formatting by the user. This results in the sidebar style table
style remaining highlighted after user direct formatting. When rows/columns are
inserted/removed direct formatted cells are untouched by autoformatting. The
table follows autoformatting style on inserts/removes. Background color
position dependency is one advantage I can see with this approach. When
insertions or deletions are made the row or column background color still
follows the autoformat style.

Approach 1 may be easier to implement.

I have made some progress on approach 2 where table boxes keep their direct
formatting of borders, line styles, number formatting, and background color,
after insertion/deletions. Working on font retention. Insertions and deletions
are made with autoformat style so the table keeps the autoformat style for
table boxes that are not direct formatted.

Other ideas are welcome.

What is the best way to do the revert? I will do a revert patch if needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180301/4feefe0f/attachment.html>