[Libreoffice-bugs] [Bug 119286] Sanitize documents using "Find & Replace" getting slower and slower

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=119286

Miklos Vajna <vmiklos at collabora.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|vmiklos at collabora.com       |

--- Comment #6 from Miklos Vajna <vmiklos at collabora.com> ---
I had a look at this: just reverting the above mentioned commit doesn't change
anything. I get why it doesn't help: the commit changes how documents
containing shapes behave and the bugdoc doesn't have shapes.

I also profiled this: SvxSearchDialog::CommandHdl_Impl() in svx is the UI code,
you can measure the cost of ExecuteSynchron():

- 97% is spent in SwFindParaText::DoFind() (OK)
  - 55% of that is sw::ReplaceImpl
  - 40% of that is sw::FindTextImpl
    - here 20% is the SvxSearchItem ctor, which is already moved out of the
loop for perf reasons
    - 18% is DoSearch

So in short, nothing obviously stupid. According to the above numbers, it
indeed smells like a regression, but I doubt it's from the above commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190402/ed2e3779/attachment.html>