[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=118809

--- Comment #12 from Lionel Elie Mamane <lionel at mamane.lu> ---
(In reply to Julien Nabet from comment #11)

> Shouldn't we put:
> sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMajorVersion(  )
> {
>     return 3;
> }
> 
> sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMinorVersion(  )
> {
>     return 0;
> }

In my understanding, this is the version of the _driver_, that is of the
sdbc-firebird code, the code in connectivity/source/firebirc. We should
increment it when we change the driver... Or we could just return the
LibreOffice version, considering that the driver is just part of LibreOffice
and has the same versioning.

The other drivers in connectivity/source don't really do this correctly either.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190830/d41d0ad0/attachment.html>