[Libreoffice-bugs] [Bug 118809] Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=118809

--- Comment #11 from Julien Nabet <serval2412 at yahoo.fr> ---
After my day time job, I'll submit a main patch with 2 suggestions:
"Firebird (engine12)" for getDatabaseProductName

result of "SELECT rdb$get_context('SYSTEM', 'ENGINE_VERSION') as version from
rdb$database" for getDatabaseProductVersion

In a second patch, I'll put 
- NumericFunctions
- StringFunctions
- TimeDateFunctions
as suggested

For driver version and name, I thought about lib used by LO.
In master we still use Firebird 3.0.0 (see
https://opengrok.libreoffice.org/xref/core/download.lst?r=df2b4a9d#48)

So I'd put:
for getDriverMajorVersion
// Retrieve version from download.lst
return OUString("3.0.0");


for getDriverName:
// Retrieve name from download.lst
Firebird-3.0.0.32483-0.tar.bz2


Also I noticed this:
sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMajorVersion(  )
{
    return 1;
}

sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMinorVersion(  )
{
    return 0;
}
See
https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/firebird/DatabaseMetaData.cxx?r=1729f554#614

Shouldn't we put:
sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMajorVersion(  )
{
    return 3;
}

sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMinorVersion(  )
{
    return 0;
}

Any thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190830/48287882/attachment-0001.html>