[Libreoffice-bugs] [Bug 63216] : Check for updates is on the help menu while most Mac apps put it on the App menu

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=63216

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbergman at redhat.com

--- Comment #18 from Julien Nabet <serval2412 at yahoo.fr> ---
Code pointer:
extensions/source/update/check/org/openoffice/Office/Addons.xcu

this file contains:
<node oor:name="OfficeHelp">
https://opengrok.libreoffice.org/xref/core/extensions/source/update/check/org/openoffice/Office/Addons.xcu?r=8dc38dd9#21

Taking a look at officecfg/registry/schema/org/openoffice/Office/Addons.xcs
I noticed these:
-
https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Addons.xcs?r=c31fa068#514
for help menu
-
https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Addons.xcs?r=c31fa068#479
for app menu?

I tried this patch:

diff --git a/extensions/Configuration_updchk.mk
b/extensions/Configuration_updchk.mk
index 394a1ae6c76d..ad543ba584b6 100644
--- a/extensions/Configuration_updchk.mk
+++ b/extensions/Configuration_updchk.mk
@@ -24,8 +24,17 @@ $(eval $(call
gb_Configuration_add_spool_modules,updchk,extensions/source/update
 # localized "Title" property values of
 # /org.openoffice.Office.Common/Menus/New/m0 (install:module="writer") end up
in
 # registry_*.xcd instead of a, say, writer_*.xcd):
+ifeq ($(OS),MACOSX)
+
+$(eval $(call
gb_Configuration_add_localized_datas,updchk,extensions/source/update/check,\
+       org/openoffice/Office/Addons_mac.xcu \
+))
+
+else
+
 $(eval $(call
gb_Configuration_add_localized_datas,updchk,extensions/source/update/check,\
        org/openoffice/Office/Addons.xcu \
 ))

+endif

copy of extensions/source/update/check/org/openoffice/Office/Addons.xcu to 
extensions/source/update/check/org/openoffice/Office/Addons_mac.xcu
changing just "OfficeHelp" to "AddonMenu"
but got this:
warning: failed to load external entity "schemaRoot"
cannot parse schemaRoot

I found schemaRoot in LO sources but don't understand how it works.

Of course, I'm not sure too that using "AddonMenu" will add "Check for Updates"
in App menu.

Stephan: since it concerns Macos and noticed some commits from you about
schemaRoot, thought you may be interested and have some ideas?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20191221/6bb42a0d/attachment-0001.htm>