[Libreoffice-bugs] [Bug 106463] Data Records Not Saved to External Firebird Database File

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=106463

--- Comment #21 from Lionel Elie Mamane <lionel at mamane.lu> ---
(In reply to Drew Jensen from comment #20)

> Firebird most certainly does support Autocommit and by default.

It seems to me it is definitely not the default at the C API level; one needs
to pass isc_tpb_autocommit as an option. Now, other Firebird UIs or drivers
probably set this option by default :)

> It must be turned off if you don't want it and the Firebird File
> SDBC does just that and turns it off during the connection process.

Reading the Firebird SDBC code, I discover it already has all the plumbing to
deal with that, but in Driver.cxx:

Reference< XConnection > SAL_CALL FirebirdDriver::connect(...)
{
    (...)
    if (url == "sdbc:embedded:firebird")
        pCon->setAutoCommit(true);
    (...)
}

Our documentation
https://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1sdbc_1_1XConnection.html#aa6e7212d2813c2b19d99dd1dc9e0ba11
clearly says:

  By default, new connections are in auto-commit mode.

*But* in Connection.cxx:

Connection::Connection()
(...)
    , m_bIsAutoCommit(false)


So, in my opinion this needs to be changed to "true", and the corresponding
lines in Driver.cxx remover as not necessary anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190128/56f85cf2/attachment.html>