[Libreoffice-bugs] [Bug 97102] Re-work copy/paste 'orrible extensions dialog code...

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=97102

--- Comment #3 from Michael Meeks <michael.meeks at collabora.com> ---
Looks like it's still there to me:


//UpdateRequiredDialog
UpdateRequiredDialog::UpdateRequiredDialog(weld::Window *pParent,
TheExtensionManager *pManager)
    : GenericDialogController(pParent, "desktop/ui/updaterequireddialog.ui",
"UpdateRequiredDialog")
    , DialogHelper(pManager->getContext(), m_xDialog.get())
    , m_sCloseText(DpResId(RID_STR_CLOSE_BTN))
    , m_bHasProgress(false)
    , m_bProgressChanged(false)
    , m_bStartProgress(false)
    , m_bStopProgress(false)
    , m_bHasLockedEntries(false)
    , m_nProgress(0)

and

ExtMgrDialog::ExtMgrDialog(weld::Window *pParent, TheExtensionManager
*pManager)
    : GenericDialogController(pParent, "desktop/ui/extensionmanager.ui",
"ExtensionManagerDialog")
    , DialogHelper(pManager->getContext(), m_xDialog.get())
    , m_sAddPackages(DpResId(RID_STR_ADD_PACKAGES))
    , m_bHasProgress(false)
    , m_bProgressChanged(false)
    , m_bStartProgress(false)
    , m_bStopProgress(false)

Look too similar. Should be some shared base-class or another helper class for
some of what they want to do with progress.

The idle handlers are still there but didn't read them yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190719/ac68c40d/attachment.html>