[Libreoffice-bugs] [Bug 125971] Image import in KDE LibreOffice fails if filename contains non-latin characters

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=125971

--- Comment #11 from Stephan Bergmann <sbergman at redhat.com> ---
(In reply to Stephan Bergmann from comment #8)
> (In reply to Jan-Marek Glogowski from comment #7)
> > I'll fix this eventually by using
> > 
> > OUString aNewURL =
> > uri::ExternalUriReferenceTranslator::create(m_xContext)-
> > >translateToInternal(toOUString(aURL.toEncoded()));
> 
> ...which, as I said on IRC, is wrong.  QUrl::toEncoded is documented
> (<https://doc.qt.io/qt-5/qurl.html#toEncoded> ) to generate a file URL whose
> "payload" is UTF-8--encoded.  But
> css.uri.XExternalUriReferenceTranslator::translateToInternal expects its
> argument to have a "payload" encoded according to the system locale (i.e.,
> osl_getThreadTextEncoding).  As QUrl provides a file URL with "payload" in
> UTF-8, which is the same format as used internally in LO, there is no need
> to map here from external to internal URL.

...but see <https://gerrit.libreoffice.org/74359> "tdf#125971: map file URLs
from QFileDialog to LO internal format" :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190619/b7224d00/attachment.html>