[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=124022

--- Comment #5 from Christian Lohmaier <cloph at documentfoundation.org> ---
adding commend from outage:
https://lists.freedesktop.org/archives/libreoffice-bugs/2019-March/176627.html
--- Comment #5 from Lionel Elie Mamane ---
(In reply to Mike Kaganski from comment #0)

> so effectively this mandates that all drivers have
> same defaults which are equal to those in
> ODatabaseModelImpl::getDefaultDataSourceSettings, breaking the per-driver
> mechanism.

IMO, having per-driver defaults is important. SDBC drivers that know which
database they connect to (e.g. MySQL, PostgreSQL, as opposed to e.g. ODBC,
JDBC, ADO) should just set the right values by default silently, and not even
give the user UI to change them to known non-working values.

> Additionally, skipping writing of the settings to ODB which are equal to
> defaults creates another problem: an ODB only has settings which are not
> equal to the defaults *of the version which was used for its last saving* -
> and if opened in another version with changed defaults, the missing settings
> take new default values, which may break the connection.

In the context of DBMS-specific drivers, on the other hand, when the default is
wrong, it allows changing the default, and fixing the connection in newer
LibreOffice versions. Else, we fix it only for files created in the new
LibreOffice version.

https://lists.freedesktop.org/archives/libreoffice-bugs/2019-March/176630.html
--- Comment #6 from Mike Kaganski ---
(In reply to Lionel Elie Mamane from comment #5)
> IMO, having per-driver defaults is important. SDBC drivers that know which
> database they connect to (e.g. MySQL, PostgreSQL, as opposed to e.g. ODBC,
> JDBC, ADO) should just set the right values by default silently, and not
> even give the user UI to change them to known non-working values.

No doubt here. My point is that currently that is broken, and must be fixed by
removing the mess when some pieces of code take one set of defaults into
account, and other takes other set, which leads to errors.

> In the context of DBMS-specific drivers, on the other hand, when the default
> is wrong, it allows changing the default, and fixing the connection in newer
> LibreOffice versions. Else, we fix it only for files created in the new
> LibreOffice version.

I don't believe this is something actually useful. If we have a broken default,
then a newly created connection of that type would be broken - so it would be
hardly usable from the beginning. On the other hand, *if* some connection
happens to be already working with this given default (even if we consider it
broken), it doesn't make sense to "fix" it (don't fix what is not broken) with
the risk of making it work unexpectedly for the user (which might have applied
some workarounds expecting the way it worked before). I don't think that it's
more important to be able to silently fix *partially created* connections (I
mean, that apparently users would start such a connection, and then abandon
because of the broken default; or edit it manually in the ODB anyway) than to
have stable connections.

https://lists.freedesktop.org/archives/libreoffice-bugs/2019-March/176631.html
--- Comment #7 from Mike Kaganski ---
... and there could be an option like "Set all inner settings to new defaults"
in the advanced settings dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190327/8efb08c1/attachment.html>