[Libreoffice-bugs] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=49033

V Stuart Foote <vstuart.foote at utsa.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needsUXEval
                 CC|                            |libreoffice-ux-advise at lists
                   |                            |.freedesktop.org

--- Comment #45 from V Stuart Foote <vstuart.foote at utsa.edu> ---
To UX-Advise to move this forward...

But my take remains that the original implementation applying the
SENTENCE_CASE, via ICU transliteration, needs additional control logic. 

Believe we need to handle two cases for applying SENTENCE_CASE in edit engine
[1].

1) Case -- an active selection made:

   expand only to the ICU -word boundaries- that hold the selection and apply
ICU transliteration. Treat that "temp" string as the sentence--and apply
transliteration.  Since the transliteration of the selection likely cross
sentence boundaries, would need to break selection into multiple "temp" strings
(an opening, middle(s), a closing)--but honor the selections at the word
boundaries as the range.

2) Case --  only text cursor focus, no selection made:

   expand only to the ICU -sentence boundaries- that hold the text cursor and
apply ICU transliteration.

The current implementation for sentence case always performs the expansion when
applying SENTENCE_CASE transliteration, with or without selection--that's the
issue. Current implementation probably could/should be retained for a no
selection case, but need to provide new code for the with selection handling.

=-ref-=
[1]
https://opengrok.libreoffice.org/xref/core/editeng/source/editeng/impedit4.cxx?r=492ea7e0#2665

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190329/bcbb4783/attachment.html>