[Libreoffice-bugs] [Bug 131907] Crash: reject/clear formatting

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=131907

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |erack at redhat.com

--- Comment #5 from Julien Nabet <serval2412 at yahoo.fr> ---
Eike:
I tested this straightforward patch and it worked:
diff --git a/sc/source/core/tool/chgtrack.cxx
b/sc/source/core/tool/chgtrack.cxx
index 0b9f18ec3779..fd720806fc2a 100644
--- a/sc/source/core/tool/chgtrack.cxx
+++ b/sc/source/core/tool/chgtrack.cxx
@@ -4191,8 +4191,7 @@ bool ScChangeTrack::Reject(
             bRejected = pAct->Reject( pDoc );
             if ( bRejected )
             {
-                // pRefDoc NULL := Do not save deleted Cells
-                AppendDeleteRange( pAct->GetBigRange().MakeRange(), nullptr,
short(0),
+                AppendDeleteRange( pAct->GetBigRange().MakeRange(), pDoc,
short(0),
                     pAct->GetActionNumber() );
             }
         }

However, it does the contrary of the comment deleted:
// pRefDoc NULL := Do not save deleted Cells

Git history of this comment gives:
commit 9964dbdda0dd8bb0471a3153ce133a76e98a09b0
Author: Philipp Weissenbacher <p.weissenbacher at gmail.com>
Date:   Thu Nov 14 12:46:35 2013 +0100

    Translate German comments

then:
commit d0484bcdcbffd42d242647a2fdc1a203d176b775
Author: Jens-Heiner Rechtien <hr at openoffice.org>
Date:   Mon Sep 18 23:16:46 2000 +0000

    initial import

Any thoughts here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200405/5c1564f8/attachment.htm>