[Libreoffice-bugs] [Bug 132147] "!!br0ken!!" is inappropriately used as an IAccessible 2 attribute for cells without formula which breaks formulas detection for assistive technologies.

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=132147

--- Comment #4 from Mike Kaganski <mikekaganski at hotmail.com> ---
"Regression" after
https://git.libreoffice.org/core/+/ab285c743afa1c8769581871d7b56374fd8c49f1

> author	Noel Grandin <noel.grandin at collabora.co.uk>	Sat Nov 02 18:59:49 2019 +0200
> committer	Noel Grandin <noel.grandin at collabora.co.uk>	Sun Nov 03 17:11:14 2019 +0100
> 
> loplugin:stringadd
> 
> tweak the plugin to be more permissive, then validate by hand
> afterwards

which replaced strFor.replaceAt(0,1,"") with strFor.copy(1). Both methods are
illegal on empty string, but the former asserted, then silently corrected wrong
count; while the latter returns "br0ken". So the change actually revealed a
pre-existing bug.

We should likely make the former also result in "br0ken" on invalid input, to
allow invalid use cases.

This hopefully will be fixed with https://gerrit.libreoffice.org/c/core/+/92301

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200416/aba2ff4d/attachment.htm>