[Libreoffice-bugs] [Bug 132301] Wrong quotation mark after a single quote which follows more than 1 letter (eg l'" -> ok, qu'" -> ko)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=132301

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=38
                   |                            |394

--- Comment #7 from Julien Nabet <serval2412 at yahoo.fr> ---
László: noticing
https://cgit.freedesktop.org/libreoffice/core/commit/?id=8039c9eb27170a162830f0ecd2086010a7a5858f
author  László Németh <nemeth at numbertext.org>   2019-12-29 12:34:34 +0100
committer       László Németh <nemeth at numbertext.org>   2019-12-29 16:36:06
+0100
commit  8039c9eb27170a162830f0ecd2086010a7a5858f (patch)
tree    d0520fefab6d1dc271ad543115cf210641675545
parent  bde382a2568147c1a5eec0cb885856cd5aaae3ad (diff)
tdf#38394 AutoCorrect: fix ’« in French l’« word »
instead of using the bad ’" -> ’» autocorrection.

Change-Id: I48adbb2e8ca8e786c7835ff186d4580e856cf3c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85945
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth at numbertext.org>
Tested-by: László Németh <nemeth at numbertext.org>

Indeed, we enter the block
1297 // tdf#38394 use opening quotation mark << in French l'<<word>>
1298 if ( !bSingle && !bSttQuote && cPrev == cApostrophe &&
1299    (nInsPos == 2 || (nInsPos > 2 && IsWordDelim( rTxt[ nInsPos-3 ] ))) )
1300 {
1301     const LanguageType eLang = GetDocLanguage( rDoc, nInsPos );
1302     if ( primary(eLang) == primary(LANGUAGE_FRENCH) )
1303         bSttQuote = true;
1304 }

(see
https://opengrok.libreoffice.org/xref/core/editeng/source/misc/svxacorr.cxx?r=c73b9868#1297)


thought you might be interested in this one.

I tried this patch and it seems to work. I mean, it works for the case here and
I used "make sw.check", no error.
However, I'd like to have your opinion because I suppose you didn't add this
check for nothing so expect some regression with it.
diff --git a/editeng/source/misc/svxacorr.cxx
b/editeng/source/misc/svxacorr.cxx
index 1242852d6213..6a8d1bbca127 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -1295,8 +1295,7 @@ void SvxAutoCorrect::DoAutoCorrect( SvxAutoCorrDoc& rDoc,
const OUString& rTxt,
                         ( cEmDash == cPrev ) ||
                         ( cEnDash == cPrev );
                     // tdf#38394 use opening quotation mark << in French
l'<<word>>
-                    if ( !bSingle && !bSttQuote && cPrev == cApostrophe &&
-                        (nInsPos == 2 || (nInsPos > 2 && IsWordDelim( rTxt[
nInsPos-3 ] ))) )
+                    if ( !bSingle && !bSttQuote && cPrev == cApostrophe &&
nInsPos >= 2  )
                     {
                         const LanguageType eLang = GetDocLanguage( rDoc,
nInsPos );
                         if ( primary(eLang) == primary(LANGUAGE_FRENCH) )

Any thoughts here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200425/8c9c80e2/attachment.htm>