[Libreoffice-bugs] [Bug 134887] New toolbar button doesn't update the icon after theme change and missing support for extra large icons

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=134887

Maxim Monastirsky <momonasmon at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
            Summary|Code support for a          |New toolbar button doesn't
                   |dedicated extra large       |update the icon after theme
                   |(32px*32px) icons in new    |change and missing support
                   |file                        |for extra large icons
           Keywords|needsUXEval                 |

--- Comment #2 from Maxim Monastirsky <momonasmon at gmail.com> ---
(In reply to Rizal Muttaqin from comment #0)
> Currently, large (24px*24px) and extra large (32px*32px) icons for creating
> a new file are using the same file so it creates blurry appearance. 
True. The code of that button wasn't adapted for the extra large size, see
NewToolbarController::setItemImage.

> The other things that the icon sometimes turn to a blank page if we change
> the LibreOffice's icon size e.g from Large to Small or change icon theme.
> Luckily this blank page use separate icon. I just question the rationale
> behind.
That's another bug. I fixed similar bugs in other toolbar buttons, but not yet
in this one. This can be fixed by implementing the XSubToolbarController
interface, which makes the button responsible for updating its icon, instead of
the toolbar implementation (which has no idea what was the last selected new
document type).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200722/071c9a34/attachment-0001.htm>