[Libreoffice-bugs] [Bug 133655] Image at wrong position after undo and moves to the original position after save & reload

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=133655

--- Comment #4 from Telesto <telesto at surfxs.nl> ---
Created attachment 161616
  --> https://bugs.documentfoundation.org/attachment.cgi?id=161616&action=edit
Bibisect log

Bisected to:
author  Michael Stahl <Michael.Stahl at cib.de>    2018-08-22 17:09:02 +0200
committer       Michael Stahl <Michael.Stahl at cib.de>    2018-09-19 10:18:29
+0200
commit  723728cd358693b8f4bc9d913541aa4479f2bd48 (patch)
tree    1ac75a662a46987301ea85d32957eb08f435ffd6
parent  41d8ca9686c7c184f586e99674b443c34bfd4f33 (diff)
sw_redlinehide_2: SwUndoDelete
This is problematic because of the calls to SplitNode.
Ideally we'd want the SplitNode to create merged frames already, but
that doesn't seem to be easy to achieve; several problems with this are:

1. the redlines are only restored at the end of UndoImpl
2. even if we store another set of SwRedlineSaveDatas right before the
   Join (while preventing the first SwRedlineSaveDatas from deleting
   them), and restore them by passing a closure to SplitNode, there
   are complaints about empty redlines, and also this case isn't
   handled properly:

     f<delete start>o<redline start>o
     b<redline end>a<redline start>r
     b<redline end>a<delete end>z

So instead, let SplitNode create whatever frames it does, and fix it up
at the end manually on the start node's frames.

This necessitates delaying the creation of the frames on the moved nodes
until the end too.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=723728cd358693b8f4bc9d913541aa4479f2bd48

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200604/0dc617b1/attachment-0001.htm>