[Libreoffice-bugs] [Bug 130979] LO7: Tooltips in cui/messages.po contain variable %MOD1 instead of string

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=130979

--- Comment #6 from Mike Kaganski <mikekaganski at hotmail.com> ---
A related idea: there's vcl::KeyCode::GetName(), which provides the key
combination name used in our menus.

We could use it instead of duplication the effort in cui/inc/tipoftheday.hrc;
e.g. making the array look like

> ...
> { NC_("RID_CUI_TIPOFTHEDAY", "Did you know that you can attach comments to portions of text? Just use the shortcut %KEYCOMBO."), "", "", vcl::KeyCode(KEY_SHIFT | KEY_MOD2 | KEY_C)},
> ...

and then just replace "%KEYCOMBO" with vcl::KeyCode(4th_elt_of_tuple).GetName()
if 4th_elt_of_tuple is not 0.

That method would (1) automatically account for macOS differences; and (2)
could allow for following extension, where you would provide a UNO name
instead, to convert it to key combination, and it would get actual key
combination -> additionally automatic account for localization differences
(some have different default key combinations) and even user-defined
preferences.

Heiko, what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201016/8071acb9/attachment.htm>