[Libreoffice-bugs] [Bug 139734] Drop redundant asserts after MacrosTest::loadFromDesktop

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=139734

--- Comment #5 from Mike Kaganski <mikekaganski at hotmail.com> ---
(In reply to Moaz El-defrawy from comment #4)
> Update: I am removed 99% of the redundant asserts and I will submit a patch
> very soon.

Very good!

> I had a question though:
> There is a pattern of asserting the return values of many functions not just
> "loadFromDesktop". Why don't we assert their return values instead just like
> "loadFromDesktop" and remove the extra ones?

This needs discussing case-by-case. In this form, I can't answer this. Which
specific change(s) you propose?

> another question:
> I am not sure how style the comments to make them more readable. I tried
> html and readme files styling but neither worked.

Are you talking about commit message, or about some comments in code? It's best
to discuss in Gerrit change, where you post some proposed change, and then
comment on parts that you are unsure with, and get responses from reviewers.

Looking forward to see the change on Gerrit. Thanks for working on this!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210220/99645f1c/attachment.htm>