[Libreoffice-bugs] [Bug 139734] Drop redundant asserts after MacrosTest::loadFromDesktop

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=139734

--- Comment #6 from Moaz El-defrawy <moaz.eldefrawy at gmail.com> ---
(In reply to Mike Kaganski from comment #5)
> (In reply to Moaz El-defrawy from comment #4)
> > Update: I am removed 99% of the redundant asserts and I will submit a patch
> > very soon.
> 
> Very good!
> 
> > I had a question though:
> > There is a pattern of asserting the return values of many functions not just
> > "loadFromDesktop". Why don't we assert their return values instead just like
> > "loadFromDesktop" and remove the extra ones?
> 
> This needs discussing case-by-case. In this form, I can't answer this. Which
> specific change(s) you propose?

I was thinking about it as a general principle and not about specific changes.
but, I just realized you I am incorrect. For example, what if we want the
function to return 0 or null at some cases. 

> 
> > another question:
> > I am not sure how style the comments to make them more readable. I tried
> > html and readme files styling but neither worked.
> 
> Are you talking about commit message, or about some comments in code? It's
> best to discuss in Gerrit change, where you post some proposed change, and
> then comment on parts that you are unsure with, and get responses from
> reviewers.

I am sorry for not being clear enough. I was asking if there is a way to style
the comments here (in this page) in case I wanted to insert some code. it seems
like '>' character is the only way to do that?

> 
> Looking forward to see the change on Gerrit. Thanks for working on this!

Thanks a lot. I am excited to finish it and move on to the next issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210221/fdbcd183/attachment.htm>