[Libreoffice-bugs] [Bug 134385] FILESAVE DOCX Don’t add space between paragraphs of the same style not overridden

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=134385

Justin L <jluth at mail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|bibisectRequest             |bibisected, bisected
                 CC|                            |jluth at mail.com,
                   |                            |kendy at collabora.com

--- Comment #5 from Justin L <jluth at mail.com> ---
repro 7.2.   Also true for .doc and .rtf formats.

I bibisected this to 6.0 IMPORT patch:
commit f8b5ecc622e2b3e82576b27bf0ded9c8eac21cae
Author: Miklos Vajna on Oct 24 09:27:19 2017 +0200
    tdf#113202 RTF import: fix lack of expected contextual spacing

HOWEVER, I wasn't comparing with MS Word. MS Word 2016 also does display any
spacing. So actually this 6.0 bibisect is a fix.

So, if I bibisect using MS Word 2016 as the verifier, then I confirm NISZ's
conclusion that it was in broken at LO 4.2 with:
commit 33e97347ac5b1a3206ddcc2c8313c7e88461bb0b
Author:     Jan Holesovsky on Oct 9 14:39:35 2013 +0200
     DOCX export: Write contextualSpacing only if it takes place.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=33e97347ac5b1a3206ddcc2c8313c7e88461bb0b

So the fix here will be to see if it inherits contextualspacing == true, and in
that case write out a false. (see
https://gerrit.libreoffice.org/c/core/+/106315 for a similar case for character
properties.)


P.S. At this point, MSWord shows RTF with no spacing - same as with 7.2.
However, DOC has spacing between every single one of the first five paragraphs
(which was mysteriously fixed shortly thereafter in the range
https://cgit.freedesktop.org/libreoffice/core/log/?id=33e97347ac5b1a3206ddcc2c8313c7e88461bb0b&qt=range&q=ff3b823ef4b867263711703fab596584314e4f58..fdba797bd9c2a3fe4de82f92c3ee815c15f8ac84)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210324/70746d61/attachment.htm>