[Libreoffice-bugs] [Bug 130795] FILEOPEN: Spreadsheet takes long to open

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=130795

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |erack at redhat.com

--- Comment #23 from Julien Nabet <serval2412 at yahoo.fr> ---
(In reply to Luboš Luňák from comment #21)
> The real problem here is not that SharedStringPool would be slow, but that
> ScTable::ValidQuery()/QueryEvaluator calls it at all. If you look at how
> it's used, those strings are interned only to do a "fast" case-insensitive
> comparison _once_, but interning a string apparently takes way longer than a
> normal comparison would. The concurrent hashmap change is band-aid (at least
> in this case), the real fix should be removing the SharedStringPool usage
> from QueryEvaluator. Bug #144249 has a similar problem.

So we could also remove the brand new lib dependency on cuckoo (unless it could
be used for something else?)

About SharedStringPool, I took a look at git history.
git log --follow -S 'svl::SharedStringPool' sc/source/core/data/table3.cxx
commit 2f39c27be2bd66f149e0a4efdd7fa37daee43fb1
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date:   Wed Oct 9 10:50:23 2013 -0400

    Use shared string's fast equality check for ValidQuery().

    Change-Id: Ib84087a10cc10a7533e64c4e8998354b52017df7

commit a11e224e07a4fda0de64a9a0a181f6034e08d2e5
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date:   Tue Oct 8 21:46:56 2013 -0400

    Store svl::SharedString in query entry items, and adjust all call sites.

    Change-Id: Ifd3bbb84c7abbe983a017a169c7e05914ef33450

Kohei was in the trio Calc experts (Eike, Kohei, Markus), so I suppose he had
done some perf tests but perhaps with all code change after all these years,
those are no more relevant?

Eike: any thoughts here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210911/6cb7758e/attachment.htm>