[Libreoffice-commits] core.git: qadevOOo/runner

[Stephan Bergmann]

 qadevOOo/runner/lib/MultiPropertyTest.java |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit daa6fe4173ba9215a7044887dc28cc8ee4408985
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Oct 22 10:56:41 2015 +0200

    Why check that resValue != oldValue
    
    ...if all we want to verify is that resValue == newValue (and it is the test
    code's responsibility to come up with a newValue != oldValue, but which might
    sometimes not be possible)?
    
    Change-Id: Ibfce322b50bb0074ca76c33ad0c83541a8d4dc41

diff --git a/qadevOOo/runner/lib/MultiPropertyTest.java b/qadevOOo/runner/lib/MultiPropertyTest.java
index 9946710..cbf8f5d 100644
--- a/qadevOOo/runner/lib/MultiPropertyTest.java
+++ b/qadevOOo/runner/lib/MultiPropertyTest.java
@@ -386,7 +386,7 @@ public class MultiPropertyTest extends MultiMethodTest
                 {
                     // if no exception thrown
                     // check that the new value is set
-                    if ((!compare(resValue, newValue)) || (compare(resValue, oldValue)))
+                    if (!compare(resValue, newValue))
                     {
                         log.println("Value for '" + propName + "' hasn't changed as expected");
                         try