[Libreoffice-commits] core.git: qadevOOo/runner

Stephan Bergmann sbergman at redhat.com
Thu Oct 22 04:52:44 PDT 2015


 qadevOOo/runner/lib/MultiPropertyTest.java |   13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

New commits:
commit d622b72e1d90670e4c8df8a512c8d161e85c2e3f
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Oct 22 13:52:01 2015 +0200

    No need to check for non-null here
    
    ...as null values are handled just fine by compare()
    
    Change-Id: Ifd17b96187ad3d13be99b107d3c3fa47e51b586e

diff --git a/qadevOOo/runner/lib/MultiPropertyTest.java b/qadevOOo/runner/lib/MultiPropertyTest.java
index 38bf2cc..53cbf09 100644
--- a/qadevOOo/runner/lib/MultiPropertyTest.java
+++ b/qadevOOo/runner/lib/MultiPropertyTest.java
@@ -406,17 +406,10 @@ public class MultiPropertyTest extends MultiMethodTest
                             log.println("\t The type seems to be an Any with value of NULL.");
                             log.println("\t Maybe the property should get its own test method.");
                         }
-                        if (resValue != null)
+                        if (!compare(resValue, oldValue))
                         {
-                            if (!compare(resValue, oldValue))
-                            {
-                                log.println("But it has changed.");
-                                tRes.tested(propName, true);
-                            }
-                            else
-                            {
-                                tRes.tested(propName, false);
-                            }
+                            log.println("But it has changed.");
+                            tRes.tested(propName, true);
                         }
                         else
                         {


More information about the Libreoffice-commits mailing list