[Libreoffice-commits] core.git: sc/source

Stephan Bergmann sbergman at redhat.com
Tue May 10 13:02:32 UTC 2016


 sc/source/ui/unoobj/servuno.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 036ed9a613c4affea26713e5762710b6d2ce09bb
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue May 10 14:59:37 2016 +0200

    Harmless missing break in switch
    
    The fallthrough will only happen if !pDocShell.  So if HAVE_FEATURE_SCRIPTING,
    the following case's if-branch is not entered, leading to break.  And if
    !HAVE_FEATURE_SCRIPTING, it leads directly to the default-branch's break.
    
    Change-Id: Ia0ac8d849ea3c762893001bfb2c64acd9725dd92

diff --git a/sc/source/ui/unoobj/servuno.cxx b/sc/source/ui/unoobj/servuno.cxx
index ddfa113..6fb931b 100644
--- a/sc/source/ui/unoobj/servuno.cxx
+++ b/sc/source/ui/unoobj/servuno.cxx
@@ -540,6 +540,7 @@ uno::Reference<uno::XInterface> ScServiceProvider::MakeInstance(
                 xRet.set(static_cast<sheet::XFormulaOpCodeMapper*>(new ScFormulaOpCodeMapperObj(::std::unique_ptr<formula::FormulaCompiler> (pComp))));
                 break;
             }
+            break;
 #if HAVE_FEATURE_SCRIPTING
         case Type::VBAOBJECTPROVIDER:
             if (pDocShell && pDocShell->GetDocument().IsInVBAMode())


More information about the Libreoffice-commits mailing list