[Libreoffice-commits] core.git: sc/source

Julien Nabet serval2412 at yahoo.fr
Wed May 11 11:31:26 UTC 2016


 sc/source/core/data/markmulti.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 40222365ceb2e16b75a16a3837da1cb27d1c2224
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Tue May 10 22:52:02 2016 +0200

    -Werror=strict-overflow
    
    sc/source/core/data/markmulti.cxx:242:50:
    assuming signed overflow does not occur when assuming that (X + c) >= X is always true
    from gcc (Debian 5.3.1-17)
        while ( nBeg != MAXROWCOUNT && nLast < nEndRow )
    
    Change-Id: Ic547a65d321577924c84b2b01b5cb2fa2ed31f8e
    Reviewed-on: https://gerrit.libreoffice.org/24863
    Reviewed-by: Eike Rathke <erack at redhat.com>
    Tested-by: Eike Rathke <erack at redhat.com>

diff --git a/sc/source/core/data/markmulti.cxx b/sc/source/core/data/markmulti.cxx
index abbe87e..ea1eb5b 100644
--- a/sc/source/core/data/markmulti.cxx
+++ b/sc/source/core/data/markmulti.cxx
@@ -222,7 +222,7 @@ void ScMultiSel::SetMarkArea( SCCOL nStartCol, SCCOL nEndCol, SCROW nStartRow, S
     // and move row marks from aRowSel to aMultiSelContainer
     if ( !bMark && aRowSel.HasMarks() )
     {
-        SCROW nBeg, nLast = nEndRow + 1;
+        SCROW nBeg, nLast = nEndRow;
         if ( aRowSel.GetMark( nStartRow ) )
         {
             nBeg = nStartRow;


More information about the Libreoffice-commits mailing list