[Libreoffice-commits] core.git: include/svtools svtools/source

Xisco Fauli anistenis at gmail.com
Thu May 26 07:46:27 UTC 2016


 include/svtools/addresstemplate.hxx        |    3 +--
 svtools/source/dialogs/addresstemplate.cxx |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 205863589da24441546f77f36fda8bc27489ac93
Author: Xisco Fauli <anistenis at gmail.com>
Date:   Thu May 26 01:26:46 2016 +0200

    tdf#89329: use unique_ptr for pImpl in addresstemplate
    
    Change-Id: I3e2cac86101e8a82eefacbe937cf40139fa77090
    Reviewed-on: https://gerrit.libreoffice.org/25473
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/include/svtools/addresstemplate.hxx b/include/svtools/addresstemplate.hxx
index 3406a26..e52b17a 100644
--- a/include/svtools/addresstemplate.hxx
+++ b/include/svtools/addresstemplate.hxx
@@ -64,8 +64,7 @@ namespace svt
         css::uno::Reference< css::container::XNameAccess >
                                m_xCurrentDatasourceTables;
 
-        AddressBookSourceDialogData*
-                               m_pImpl;
+        std::unique_ptr<AddressBookSourceDialogData> m_pImpl;
 
     public:
         AddressBookSourceDialog( vcl::Window* _pParent,
diff --git a/svtools/source/dialogs/addresstemplate.cxx b/svtools/source/dialogs/addresstemplate.cxx
index 073d890..e6118aa 100644
--- a/svtools/source/dialogs/addresstemplate.cxx
+++ b/svtools/source/dialogs/addresstemplate.cxx
@@ -729,7 +729,7 @@ void AssignmentPersistentData::ImplCommit()
 
     void AddressBookSourceDialog::dispose()
     {
-        delete m_pImpl;
+        m_pImpl.reset();
         m_pDatasource.clear();
         m_pAdministrateDatasources.clear();
         m_pTable.clear();


More information about the Libreoffice-commits mailing list