[Libreoffice-commits] core.git: include/svtools svtools/source

Xisco Fauli anistenis at gmail.com
Thu May 26 13:39:34 UTC 2016


 include/svtools/transfer.hxx      |    2 +-
 svtools/source/misc/transfer2.cxx |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 86d84ae4bba0d4c45bc13232645318291a8aed75
Author: Xisco Fauli <anistenis at gmail.com>
Date:   Thu May 26 01:50:38 2016 +0200

    tdf#89329: use unique_ptr for pImpl in transfer
    
    Change-Id: Ia28a7bd63c8f3a06ef2fd508619bae3a31af450c
    Reviewed-on: https://gerrit.libreoffice.org/25479
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noelgrandin at gmail.com>

diff --git a/include/svtools/transfer.hxx b/include/svtools/transfer.hxx
index 9734c89..ea50c8e 100644
--- a/include/svtools/transfer.hxx
+++ b/include/svtools/transfer.hxx
@@ -481,7 +481,7 @@ struct TransferDataContainer_Impl;
 
 class SVT_DLLPUBLIC TransferDataContainer : public TransferableHelper
 {
-    TransferDataContainer_Impl* pImpl;
+    std::unique_ptr<TransferDataContainer_Impl> pImpl;
 
 protected:
 
diff --git a/svtools/source/misc/transfer2.cxx b/svtools/source/misc/transfer2.cxx
index 3d3a7c6..782b804 100644
--- a/svtools/source/misc/transfer2.cxx
+++ b/svtools/source/misc/transfer2.cxx
@@ -344,7 +344,6 @@ TransferDataContainer::TransferDataContainer()
 
 TransferDataContainer::~TransferDataContainer()
 {
-    delete pImpl;
 }
 
 


More information about the Libreoffice-commits mailing list