[Libreoffice-commits] core.git: compilerplugins/clang
Noel Grandin
noel.grandin at collabora.co.uk
Mon Nov 14 11:57:04 UTC 2016
compilerplugins/clang/unusedmethods.py | 3 +++
1 file changed, 3 insertions(+)
New commits:
commit 391c6aeeed289678446a5f6f4d039ef92eb284d4
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Mon Nov 14 11:32:06 2016 +0200
ignore constructors for method-can-be-private analysis
doesn't work right now
Change-Id: I43693104f4af204a6bd0c22b0f7ef53c1a14bb6e
diff --git a/compilerplugins/clang/unusedmethods.py b/compilerplugins/clang/unusedmethods.py
index 1f6c2bc..bf05c2f 100755
--- a/compilerplugins/clang/unusedmethods.py
+++ b/compilerplugins/clang/unusedmethods.py
@@ -333,6 +333,9 @@ for d in publicDefinitionSet:
method = d[0] + " " + d[1]
if d in calledFromOutsideSet:
continue
+ # TODO ignore constructors for now, my called-from-outside analysis doesn't work here
+ if d[0] == "":
+ continue
if isOtherConstness(d, calledFromOutsideSet):
continue
# ignore external code
More information about the Libreoffice-commits
mailing list