[Libreoffice-commits] core.git: compilerplugins/clang

Stephan Bergmann sbergman at redhat.com
Mon Nov 14 15:48:02 UTC 2016


 compilerplugins/clang/unnecessaryoverride.cxx |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 682899e313bb5a201289dfcfd30cc7caec0945a6
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Mon Nov 14 16:47:25 2016 +0100

    CXXDestructorDecl is already handled
    
    ...a few lines up, together with CXXConstructorDecl
    
    Change-Id: Id9afd4d3936b2efb92de3c6ab950da78d876a5a8

diff --git a/compilerplugins/clang/unnecessaryoverride.cxx b/compilerplugins/clang/unnecessaryoverride.cxx
index 953abcb..64239a6 100644
--- a/compilerplugins/clang/unnecessaryoverride.cxx
+++ b/compilerplugins/clang/unnecessaryoverride.cxx
@@ -85,9 +85,6 @@ bool UnnecessaryOverride::VisitCXXMethodDecl(const CXXMethodDecl* methodDecl)
             return true;
         }
     }
-    if (dyn_cast<CXXDestructorDecl>(methodDecl)) {
-        return true;
-    }
     // sometimes the disambiguation happens in a base class
     StringRef aFileName = compiler.getSourceManager().getFilename(compiler.getSourceManager().getSpellingLoc(methodDecl->getLocStart()));
     if (aFileName == SRCDIR "/comphelper/source/property/propertycontainer.cxx")


More information about the Libreoffice-commits mailing list