[Libreoffice-commits] core.git: sc/source

Kohei Yoshida kohei.yoshida at collabora.com
Mon Oct 3 21:54:58 UTC 2016


 sc/source/core/data/formulacell.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 191e0258427f2209f21384b4e4c685efda24ac03
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date:   Sun Oct 2 20:41:53 2016 -0400

    Reverse the boolean logic.
    
    To have the 'true' value associate with action and 'false' with
    inaction.
    
    Change-Id: Icf61b1cb8642a72390d1f2aa45ca25fb67ec0dbd

diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx
index cb4bb4d..917fcd4 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -1292,7 +1292,7 @@ void ScFormulaCell::CompileXML( sc::CompileFormulaContext& rCxt, ScProgress& rPr
     // pCode may not deleted for queries, but must be empty
     pCode->Clear();
 
-    bool bSkipCompile = false;
+    bool bDoCompile = true;
 
     if ( !mxGroup && aFormulaNmsp.isEmpty() ) // optimization
     {
@@ -1328,7 +1328,7 @@ void ScFormulaCell::CompileXML( sc::CompileFormulaContext& rCxt, ScProgress& rPr
                 if (bSubTotal)
                     pDocument->AddSubTotalCell(this);
 
-                bSkipCompile = true;
+                bDoCompile = false;
                 pCode = pPreviousCell->pCode;
                 if (pPreviousCell->mbIsExtRef)
                     pDocument->GetExternalRefManager()->insertRefCellFromTemplate( pPreviousCell, this );
@@ -1339,7 +1339,7 @@ void ScFormulaCell::CompileXML( sc::CompileFormulaContext& rCxt, ScProgress& rPr
         }
     }
 
-    if (!bSkipCompile)
+    if (bDoCompile)
     {
         ScTokenArray* pCodeOld = pCode;
         pCode = aComp.CompileString( aFormula, aFormulaNmsp );


More information about the Libreoffice-commits mailing list