[Libreoffice-commits] core.git: sc/source

Kohei Yoshida kohei.yoshida at collabora.com
Tue Oct 4 03:50:27 UTC 2016


 sc/source/core/data/formulacell.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit f309531cfe1d6a1b6ea1306d45ed3e121145bc5f
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date:   Mon Oct 3 23:12:38 2016 -0400

    Add a bit more description here.
    
    We are creating a formula string using the tokens from the previous cell
    to see what it would look like if the current cell was grouped with it,
    then perform string comparison to evaluate for grouping.
    
    Change-Id: I29b780d44bec16c0b42990837b70435e059c7594
    Reviewed-on: https://gerrit.libreoffice.org/29516
    Reviewed-by: Kohei Yoshida <libreoffice at kohei.us>
    Tested-by: Kohei Yoshida <libreoffice at kohei.us>

diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx
index 917fcd4..de5fc68 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -1301,7 +1301,8 @@ void ScFormulaCell::CompileXML( sc::CompileFormulaContext& rCxt, ScProgress& rPr
         ScFormulaCell *pPreviousCell = pDocument->GetFormulaCell( aPreviousCell );
         if( pPreviousCell )
         {
-            // Now try to convert to a string quickly ...
+            // Build formula string using the tokens from the previous cell,
+            // but use the current cell position.
             ScCompiler aBackComp( rCxt, aPos, *(pPreviousCell->pCode) );
             OUStringBuffer aShouldBeBuf;
             aBackComp.CreateStringFromTokenArray( aShouldBeBuf );


More information about the Libreoffice-commits mailing list