[Libreoffice-commits] core.git: include/sfx2 include/svl include/svtools sfx2/source svtools/source svx/source
Noel Grandin
noel.grandin at collabora.co.uk
Tue Nov 28 08:51:53 UTC 2017
include/sfx2/controlwrapper.hxx | 8 ++++----
include/sfx2/dispatch.hxx | 2 +-
include/sfx2/filedlghelper.hxx | 2 +-
include/sfx2/infobar.hxx | 2 +-
include/sfx2/itemconnect.hxx | 12 ++++++------
include/sfx2/objsh.hxx | 2 +-
include/sfx2/sfxbasemodel.hxx | 2 +-
include/svl/itemset.hxx | 4 ++--
include/svl/urihelper.hxx | 2 +-
include/svl/visitem.hxx | 2 +-
include/svtools/editbrowsebox.hxx | 2 +-
sfx2/source/dialog/itemconnect.cxx | 1 +
svtools/source/filter/exportdialog.hxx | 2 +-
svx/source/unodraw/unomod.cxx | 2 +-
14 files changed, 23 insertions(+), 22 deletions(-)
New commits:
commit c3a2d6f9fbdc0ea5c23e0e662f238b23e9c00035
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Tue Nov 28 08:43:03 2017 +0200
loplugin:countusersofdefaultparams in sfx2..svtools
Change-Id: I65ae5305f9cec14069fd7aef6613e981dbbed846
Reviewed-on: https://gerrit.libreoffice.org/45382
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/include/sfx2/controlwrapper.hxx b/include/sfx2/controlwrapper.hxx
index 34740a48c02e..debb76ac1d68 100644
--- a/include/sfx2/controlwrapper.hxx
+++ b/include/sfx2/controlwrapper.hxx
@@ -79,7 +79,7 @@ public:
is used (simply casting between list position and values). If the map
exists, it *MUST* be terminated by an entry containing the special
"not found" list position. */
- explicit PosValueMapper( PosT nNFPos, const MapEntryType* pMap = nullptr ) :
+ explicit PosValueMapper( PosT nNFPos, const MapEntryType* pMap ) :
mpMap( pMap ), mnNFPos( nNFPos ) {}
/** Returns the value at the specified list position.
@@ -251,7 +251,7 @@ template< typename ValueT >
class MetricFieldWrapper : public SingleControlWrapper< MetricField, ValueT >
{
public:
- explicit MetricFieldWrapper( MetricField& rField, FieldUnit eUnit = FUNIT_NONE ) :
+ explicit MetricFieldWrapper( MetricField& rField, FieldUnit eUnit ) :
SingleControlWrapper< MetricField, ValueT >( rField ), meUnit( eUnit ) {}
virtual bool IsControlDontKnow() const SAL_OVERRIDE;
@@ -285,7 +285,7 @@ public:
/** @param pMap Optional list position <-> value map.
See PosValueMapper documentation for details. */
- explicit ListBoxWrapper( ListBox& rListBox, const MapEntryType* pMap = nullptr ) :
+ explicit ListBoxWrapper( ListBox& rListBox, const MapEntryType* pMap ) :
SingleControlWrapper< ListBox, ValueT >( rListBox ), MapperType( WRAPPER_LISTBOX_ENTRY_NOTFOUND, pMap ) {}
virtual bool IsControlDontKnow() const SAL_OVERRIDE
@@ -318,7 +318,7 @@ public:
/** @param pMap Optional position <-> value map.
See PosValueMapper documentation for details. */
- explicit ValueSetWrapper( ValueSet& rValueSet, const MapEntryType* pMap = nullptr ) :
+ explicit ValueSetWrapper( ValueSet& rValueSet, const MapEntryType* pMap ) :
SingleControlWrapper< ValueSet, ValueT >( rValueSet ), MapperType( WRAPPER_VALUESET_ITEM_NOTFOUND, pMap ) {}
virtual bool IsControlDontKnow() const SAL_OVERRIDE
diff --git a/include/sfx2/dispatch.hxx b/include/sfx2/dispatch.hxx
index e8ad3783c9f8..3daa2b0087d8 100644
--- a/include/sfx2/dispatch.hxx
+++ b/include/sfx2/dispatch.hxx
@@ -129,7 +129,7 @@ public:
SfxItemSet const * pArgs,
SfxItemSet const * pInternalArgs,
sal_uInt16 nModi,
- vcl::Window* pDialogParent = nullptr);
+ vcl::Window* pDialogParent);
const SfxPoolItem* ExecuteList( sal_uInt16 nSlot,
SfxCallMode nCall,
diff --git a/include/sfx2/filedlghelper.hxx b/include/sfx2/filedlghelper.hxx
index 6c6a4f090c3f..9fd312f87123 100644
--- a/include/sfx2/filedlghelper.hxx
+++ b/include/sfx2/filedlghelper.hxx
@@ -252,7 +252,7 @@ ErrCode FileOpenDialog_Impl( const vcl::Window* pParent,
SfxItemSet *& rpSet,
const OUString* pPath,
sal_Int16 nDialog,
- const OUString& rStandardDir = OUString(),
+ const OUString& rStandardDir,
const css::uno::Sequence< OUString >& rBlackList = css::uno::Sequence< OUString >());
diff --git a/include/sfx2/infobar.hxx b/include/sfx2/infobar.hxx
index 4e49213c19f6..23953a1a7bf7 100644
--- a/include/sfx2/infobar.hxx
+++ b/include/sfx2/infobar.hxx
@@ -93,7 +93,7 @@ class SfxInfoBarContainerWindow : public vcl::Window
VclPtr<SfxInfoBarWindow> appendInfoBar(const OUString& sId,
const OUString& sMessage,
InfoBarType ibType,
- WinBits nMessageStyle = WB_LEFT|WB_VCENTER);
+ WinBits nMessageStyle);
VclPtr<SfxInfoBarWindow> getInfoBar(const OUString& sId);
bool hasInfoBarWithID(const OUString& sId);
void removeInfoBar(VclPtr<SfxInfoBarWindow> const & pInfoBar);
diff --git a/include/sfx2/itemconnect.hxx b/include/sfx2/itemconnect.hxx
index f64fa2deff2b..a14361103bce 100644
--- a/include/sfx2/itemconnect.hxx
+++ b/include/sfx2/itemconnect.hxx
@@ -180,7 +180,7 @@ public:
bool DoFillItemSet( SfxItemSet& rDestSet, const SfxItemSet& rOldSet );
protected:
- explicit ItemConnectionBase( ItemConnFlags nFlags = ItemConnFlags::NONE );
+ explicit ItemConnectionBase( ItemConnFlags nFlags );
/** Derived classes implement actions according to current flags here. */
virtual void ApplyFlags( const SfxItemSet* pItemSet ) = 0;
@@ -223,7 +223,7 @@ public:
/** Receives pointer to a newly created control wrapper.
@descr Takes ownership of the control wrapper. */
explicit ItemControlConnection( sal_uInt16 nSlot, ControlWrpT* pNewCtrlWrp,
- ItemConnFlags nFlags = ItemConnFlags::NONE );
+ ItemConnFlags nFlags );
/** Convenience constructor. Receives reference to a control directly.
@descr May only be used, if ControlWrpT::ControlWrpT( ControlType& )
@@ -261,7 +261,7 @@ class SFX2_DLLPUBLIC DummyItemConnection:
{
public:
explicit DummyItemConnection( sal_uInt16 nSlot, vcl::Window& rWindow,
- ItemConnFlags nFlags = ItemConnFlags::NONE );
+ ItemConnFlags nFlags );
protected:
virtual void ApplyFlags( const SfxItemSet* pItemSet ) override;
@@ -296,7 +296,7 @@ public:
typedef typename ItemControlConnectionType::ControlWrapperType MetricFieldWrapperType;
explicit MetricConnection( sal_uInt16 nSlot, MetricField& rField,
- FieldUnit eItemUnit = FUNIT_NONE, ItemConnFlags nFlags = ItemConnFlags::NONE );
+ FieldUnit eItemUnit, ItemConnFlags nFlags = ItemConnFlags::NONE );
};
@@ -321,7 +321,7 @@ public:
typedef typename ListBoxWrapperType::MapEntryType MapEntryType;
explicit ListBoxConnection( sal_uInt16 nSlot, ListBox& rListBox,
- const MapEntryType* pMap = nullptr, ItemConnFlags nFlags = ItemConnFlags::NONE );
+ const MapEntryType* pMap, ItemConnFlags nFlags = ItemConnFlags::NONE );
};
@@ -346,7 +346,7 @@ public:
typedef typename ValueSetWrapperType::MapEntryType MapEntryType;
explicit ValueSetConnection( sal_uInt16 nSlot, ValueSet& rValueSet,
- const MapEntryType* pMap = nullptr, ItemConnFlags nFlags = ItemConnFlags::NONE );
+ const MapEntryType* pMap, ItemConnFlags nFlags = ItemConnFlags::NONE );
};
diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx
index b514989055bc..51f7363e619c 100644
--- a/include/sfx2/objsh.hxx
+++ b/include/sfx2/objsh.hxx
@@ -366,7 +366,7 @@ public:
virtual VclPtr<SfxDocumentInfoDialog> CreateDocumentInfoDialog( const SfxItemSet& );
ErrCode CallBasic( const OUString& rMacro, const OUString& rBasicName,
- SbxArray* pArgs = nullptr, SbxValue* pRet = nullptr );
+ SbxArray* pArgs, SbxValue* pRet = nullptr );
ErrCode CallXScript(
const OUString& rScriptURL,
diff --git a/include/sfx2/sfxbasemodel.hxx b/include/sfx2/sfxbasemodel.hxx
index e721a77e35f4..5c88f54d5fb3 100644
--- a/include/sfx2/sfxbasemodel.hxx
+++ b/include/sfx2/sfxbasemodel.hxx
@@ -172,7 +172,7 @@ public:
// constructor/destructor
- SfxBaseModel( SfxObjectShell *pObjectShell = nullptr ) ;
+ SfxBaseModel( SfxObjectShell *pObjectShell ) ;
virtual ~SfxBaseModel() override ;
diff --git a/include/svl/itemset.hxx b/include/svl/itemset.hxx
index 9291fd430421..c3715177810c 100644
--- a/include/svl/itemset.hxx
+++ b/include/svl/itemset.hxx
@@ -166,7 +166,7 @@ public:
/// Templatized static version of GetItem() to directly return the correct type if the SfxItemSet is available.
- template<class T> static const T* GetItem(const SfxItemSet* pItemSet, sal_uInt16 nWhich, bool bSearchInParent = true)
+ template<class T> static const T* GetItem(const SfxItemSet* pItemSet, sal_uInt16 nWhich, bool bSearchInParent)
{
if (pItemSet)
return pItemSet->GetItem<T>(nWhich, bSearchInParent);
@@ -201,7 +201,7 @@ public:
bool Put( const SfxItemSet&,
bool bInvalidAsDefault = true );
void PutExtended( const SfxItemSet&,
- SfxItemState eDontCareAs = SfxItemState::UNKNOWN,
+ SfxItemState eDontCareAs,
SfxItemState eDefaultAs = SfxItemState::UNKNOWN );
bool Set( const SfxItemSet&, bool bDeep = true );
diff --git a/include/svl/urihelper.hxx b/include/svl/urihelper.hxx
index fd4039e5da8f..6b5a2fc2ff36 100644
--- a/include/svl/urihelper.hxx
+++ b/include/svl/urihelper.hxx
@@ -147,7 +147,7 @@ SVL_DLLPUBLIC OUString FindFirstURLInText(OUString const & rText,
@return The input URI with any password component removed.
*/
SVL_DLLPUBLIC OUString removePassword(OUString const & rURI,
- INetURLObject::EncodeMechanism eEncodeMechanism = INetURLObject::EncodeMechanism::WasEncoded,
+ INetURLObject::EncodeMechanism eEncodeMechanism,
INetURLObject::DecodeMechanism eDecodeMechanism = INetURLObject::DecodeMechanism::ToIUri,
rtl_TextEncoding eCharset = RTL_TEXTENCODING_UTF8);
diff --git a/include/svl/visitem.hxx b/include/svl/visitem.hxx
index a5a481fa2a6c..af382c426bc3 100644
--- a/include/svl/visitem.hxx
+++ b/include/svl/visitem.hxx
@@ -30,7 +30,7 @@ class SVL_DLLPUBLIC SfxVisibilityItem: public SfxPoolItem
public:
- explicit SfxVisibilityItem(sal_uInt16 which, bool bVisible = true):
+ explicit SfxVisibilityItem(sal_uInt16 which, bool bVisible):
SfxPoolItem(which)
{
m_nValue.bVisible = bVisible;
diff --git a/include/svtools/editbrowsebox.hxx b/include/svtools/editbrowsebox.hxx
index 0e033382bfb4..1f5ab12dc3cc 100644
--- a/include/svtools/editbrowsebox.hxx
+++ b/include/svtools/editbrowsebox.hxx
@@ -584,7 +584,7 @@ namespace svt
// secure starting of StartEditHdl
public:
- EditBrowseBox(vcl::Window* pParent, EditBrowseBoxFlags nBrowserFlags, WinBits nBits = WB_TABSTOP, BrowserMode nMode = BrowserMode::NONE );
+ EditBrowseBox(vcl::Window* pParent, EditBrowseBoxFlags nBrowserFlags, WinBits nBits, BrowserMode nMode = BrowserMode::NONE );
virtual ~EditBrowseBox() override;
virtual void dispose() override;
diff --git a/sfx2/source/dialog/itemconnect.cxx b/sfx2/source/dialog/itemconnect.cxx
index 891cc846c584..397856136bd2 100644
--- a/sfx2/source/dialog/itemconnect.cxx
+++ b/sfx2/source/dialog/itemconnect.cxx
@@ -281,6 +281,7 @@ bool ItemConnectionArrayImpl::FillItemSet( SfxItemSet& rDestSet, const SfxItemSe
ItemConnectionArray::ItemConnectionArray() :
+ ItemConnectionBase(ItemConnFlags::NONE),
mxImpl( new ItemConnectionArrayImpl )
{
}
diff --git a/svtools/source/filter/exportdialog.hxx b/svtools/source/filter/exportdialog.hxx
index b8bf28321f1e..a6fb96e77e2a 100644
--- a/svtools/source/filter/exportdialog.hxx
+++ b/svtools/source/filter/exportdialog.hxx
@@ -176,7 +176,7 @@ public:
const css::uno::Reference< css::uno::XComponentContext >& rxContext,
const css::uno::Reference< css::lang::XComponent >& rxSourceDocument,
bool bExportSelection, bool bIsExportVectorFormat, bool bGraphicsSource,
- const css::uno::Reference< css::graphic::XGraphic >& rxGraphic = nullptr);
+ const css::uno::Reference< css::graphic::XGraphic >& rxGraphic);
virtual ~ExportDialog() override;
virtual void dispose() override;
};
diff --git a/svx/source/unodraw/unomod.cxx b/svx/source/unodraw/unomod.cxx
index 93f86755bdda..70303e95edc4 100644
--- a/svx/source/unodraw/unomod.cxx
+++ b/svx/source/unodraw/unomod.cxx
@@ -247,7 +247,7 @@ uno::Sequence< OUString > SvxUnoDrawMSFactory::concatServiceNames( uno::Sequence
}
SvxUnoDrawingModel::SvxUnoDrawingModel( SdrModel* pDoc ) throw()
-: mpDoc( pDoc )
+: SfxBaseModel(nullptr), mpDoc( pDoc )
{
}
More information about the Libreoffice-commits
mailing list