[Libreoffice-commits] core.git: Changes to 'feature/lok_dialog2'

Tue Nov 28 09:30:34 UTC 2017

New branch 'feature/lok_dialog2' available with the following commits:
commit f34d760f31f0d4e0e75bc1ce70b7f0fa98894197
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Tue Nov 28 02:53:48 2017 +0530

    WIP: Remove getDialogInfo + gtv
    
    Change-Id: I6f810c97f2fadd3b1ea602a97e24c8b42f4a84b9

commit 2717196226b6a75a1e2334e32493f5776d888660
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Tue Nov 28 02:25:36 2017 +0530

    lokdialog: Notify the current view only
    
    Change-Id: I55e0dbf1677a24905d337c58184a4419c1020a87

commit 3d2c9d2d0569647e1fdde4bba548c174338fc15c
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Tue Nov 28 01:44:46 2017 +0530

    lokdialog: new callback size_changed with new size of the dialog
    
    Change-Id: Ibb864cb588ae7db92381c5578701d3ce09185f34

commit 53a1daacfb53b07e2b7d4a97076667e055edb808
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Tue Nov 28 01:21:38 2017 +0530

    lokdialog: Emit "created" callback after initial dialog layouting
    
    StateChangeType::InitShow is a good indicator that layouting has
    finished; we can rely that the size as returned by vcl::Window will be
    correct.
    
    The problem previously was that borders were not calculated by the time
    "created" callback was emitted resulting in incorrect returned window
    size.
    
    Change-Id: I878c210dc2e7b3fe99123fe126830f58dc97feba

commit 1fe54835fc30d7f5e54276a7fef254fc3e03520b
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Mon Nov 27 23:25:35 2017 +0530

    etags: pass the "-e" flag directly to ctag binary
    
    'man ctags' says that emacs mode will be enabled if the ctags binary is
    renamed as etags or '-e' flag is provided to ctags binary.
    
    Before this patch, the script assumes that host system has an 'etags'
    binary renamed from 'ctags' program. This is not always the case in all
    hosts. Eg: In Fedora, 'etags' binary is provided by emacs-common package
    which doesn't understand the flags given later in the script.
    
    It is safe to just explicitly enable the emacs mode via '-e' flag to the
    ctags binary.
    
    Change-Id: Ic7ded56cff32683fc5e9d3fcc7405e79da4c23b7

commit e5a1e6405b6aa89117eb7e32d27e5d47fb3b5596
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Mon Nov 27 21:05:56 2017 +0530

    lokdialog: Emit callback when title is changed
    
    The plan is to remove the getDialogInfo from LOK API but one more step
    before doing that is to find out why the dialog size in 'created'
    dialog callback is less than what the actual dialog after painting is.
    
    Change-Id: I5176e175cbf7ed81c1465feeeea053c9a024fbd9

commit c6bcf9c315bd7cdb0c60fbce8bd090f1292f9438
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Fri Nov 24 18:40:01 2017 +0530

    lokdialog: Launch dialogs which have a notifier registered
    
    Change-Id: I062fa291668b7dbfb8bc8e8d455a7933378ce7d9

commit 5b959084890dcb27be663667258b01adf3f789ae
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Mon Nov 27 19:23:22 2017 +0100

    lokdialog: Move the LOKWindowId <-> VclPtr<Window> mapping to Window.
    
    This allows registering & de-registering of non-sfx windows too, and makes the
    Calc autofilter popup to appear.
    
    Change-Id: I7cbbe94d208115aabcb6fa5f964646c7b7ce4c93

commit 23a0dea5294e5e5b1d320adc26aadd6c6b735d99
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Mon Nov 27 15:03:19 2017 +0100

    lokdialog: Move the LogicInvalidate from Dialog down to Window.
    
    Another step towards the autofilter popup working...
    
    Change-Id: I4907a23fcd0fc64da0c7f51e2f36b1657a17638c

commit 8a002215c36204fc31425a9a434fd604e439c71c
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Fri Nov 24 18:50:05 2017 +0100

    lokdialog: Move the painting down to Window, and enable Calc and Impress.
    
    Tested with .uno:FormatCellDialog in Calc, Impress not tested.
    
    Change-Id: I6d911c29616988db0625be9e2a63cf2172c69ee8

commit a95b18a17b0b6305c2016b35276ff5ce03ad6cf1
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Fri Nov 24 12:06:42 2017 +0100

    lokdialogs: Assign the LOK window id only when necessary.
    
    Change-Id: Id48957a8c2bde068f30bb26e66df81972fe38e0f

commit f45c385f039668cecbcc6c1c257c96a2f982be90
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Fri Nov 24 11:21:13 2017 +0100

    lokdialog: Make the Autofilter popup notify about its creation.
    
    Change-Id: Ib4062fa887b44eb1368205a414f4ac162f648c5c

commit 9f1ce4a70535e51b6561a8f064b8889cedc183f7
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Fri Nov 24 10:20:47 2017 +0100

    lokdialog: Move the Notifier down to vcl::Window.
    
    We need to tunnel more than just dialogs, so this is the 1st step to get the
    Autofilter popup rendered.
    
    Change-Id: I6523a39ddc7a6eb2a204e48ab364130a5822f548

commit 6466cd06917968b0f8a574e0151d60f0cadfc814
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Fri Nov 24 02:27:09 2017 +0530

    lokdialog: Let all modal dialogs notify about creation, disposal
    
    Change-Id: I8ec0ad81abcf1adf628906b02f7f94ab74a550b5

commit 92185da43398ad66e51c6d72c6846eb5f7d3f994
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Fri Nov 24 01:56:25 2017 +0530

    lokdialog: Notify to child helper method, not the main one
    
    Change-Id: I0698bfe578cb122dfabed566cb7a096f3cb56af5

commit fe8bbe55ee4824eaf0ac8668755d5cddc27590ff
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Fri Nov 24 01:49:21 2017 +0530

    lokdialog: Let modeless dialogs emit "created" callback too
    
    Change-Id: Ie81f8bd19696e6f0abceb86369545766918ae46a

commit 1928c7a9b6b5e8262fcbeebe5bb502c1e85ab499
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Fri Nov 24 01:40:38 2017 +0530

    lokdialog: Notify dialog closure from sfx2/, instead of vcl/
    
    Change-Id: I49f5e0d5f6c7c0077a6d4390f8788c1691d47bd6

commit 9f9b572a72db5a762ccb9d81f0834bc47d8501b2
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Fri Nov 24 01:40:13 2017 +0530

    gtv: Kill dialog selector combo box
    
    Change-Id: I2cd27dff95f2bc49a15ab395b8282b5496e1e229

commit 77d9a33f4a08782038d1f13e89e2413f6f1945cb
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Fri Nov 24 01:20:56 2017 +0530

    lokdialog: Make vcl::DialogID an integer
    
    This will help launching multiple instances of dialog from multiple
    views. The earlier approach of using the UNO command strings as dialog
    id would not have been useful for multi-view case.
    
    Change-Id: I01cfb3c8b204d5654df2417efdac6b50dc920f0e

commit aaaa94ec3b19dcf3e387d6fa24d856b7743f2bb6
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Thu Nov 23 21:07:07 2017 +0530

    lokdialog: Create dialog when callback is received
    
    With this, we do away with initial approach of rendering the dialog on a
    large surface. We now create the cairo surface with dimensions of the
    dialog.
    
    Change-Id: Icb034693c7f1c656b7daae7f5c711b5bd4d8e880

commit 51ef44ed5adc5b0c585b346dac70b16b1df0b97e
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Thu Nov 23 21:00:55 2017 +0530

    lokdialog: gtv: Add width and height props to Dialog GObject
    
    Change-Id: I488a94d9c6cefd37624f755c6308f0b75595df84

commit cef08cd8f3619990807f17be12ee52c4379f595f
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Wed Nov 22 22:25:20 2017 +0530

    lokdialog: Changed dialog painting to allow for modal dialogs
    
    Split IDialogNotifier from IDialogRenderable and make SfxViewShell
    implement it.
    
    We now just send the dialog UNO command to the backend and wait for core
    to emit a 'created' dialog callback which signals dialog creation in the
    backend. The client is then supposed to send the paint commands for
    rendering the dialog.
    
    Change-Id: I1bfbce83c17955fa0212408376d6bcd1b2d2d1dd

commit 0317cc03cb663b69bfc91d45333d0e6e5bdf4f20
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Wed Nov 22 22:04:58 2017 +0530

    Use SfxModalDialog class as Hyperlink dialog's base
    
    Change-Id: I1f592fdb5825896ad8fbe55c182936ed4ed98efc