[Libreoffice-commits] core.git: sc/IwyuFilter_sc.yaml sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Aug 28 16:31:52 UTC 2018 

 sc/IwyuFilter_sc.yaml                       |    4 ++++
 sc/source/core/data/bcaslot.cxx             |    1 +
 sc/source/core/data/document.cxx            |    1 +
 sc/source/core/data/grouptokenconverter.cxx |    3 +++
 sc/source/core/data/simpleformulacalc.cxx   |    1 +
 sc/source/core/data/table2.cxx              |    1 +
 sc/source/core/inc/addinlis.hxx             |    6 +++---
 sc/source/core/inc/adiasync.hxx             |    1 +
 sc/source/core/inc/bcaslot.hxx              |   10 +++++-----
 sc/source/core/inc/cellkeytranslator.hxx    |    3 +--
 sc/source/core/inc/ddelink.hxx              |    3 ++-
 sc/source/core/inc/grouptokenconverter.hxx  |    8 +++++---
 sc/source/core/inc/interpre.hxx             |   11 +++--------
 sc/source/core/inc/jumpmatrix.hxx           |    4 ++--
 sc/source/core/inc/parclass.hxx             |    1 -
 sc/source/core/inc/webservicelink.hxx       |   15 +++++++++++++--
 sc/source/core/tool/addincol.cxx            |    1 +
 sc/source/core/tool/addinlis.cxx            |    2 ++
 sc/source/core/tool/cellkeytranslator.cxx   |    1 +
 sc/source/core/tool/interpr7.cxx            |    1 +
 20 files changed, 51 insertions(+), 27 deletions(-)

New commits:
commit dfb30a0b5c1f36f44e8806d9491cced343f4b8fd
Author:     Gabor Kelemen <kelemeng at ubuntu.com>
AuthorDate: Thu Aug 23 00:19:02 2018 +0200
Commit:     Miklos Vajna <vmiklos at collabora.co.uk>
CommitDate: Tue Aug 28 18:31:27 2018 +0200

    tdf#42949 Fix IWYU warnings in sc/source/core/inc/*
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here.
    
    Change-Id: I5af85ef9ed3e6d15f7e98e9d669c59a66fc70833
    Reviewed-on: https://gerrit.libreoffice.org/59478
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index b67bf7f9be83..0a369ba44f78 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -365,3 +365,7 @@ blacklist:
     sc/inc/unitconv.hxx:
     # base class has to be a complete type
     - map
+    sc/source/core/inc/addinlis.hxx:
+    # base class has to be a complete type
+    - com/sun/star/lang/XServiceInfo.hpp
+    - com/sun/star/sheet/XResultListener.hpp
diff --git a/sc/source/core/data/bcaslot.cxx b/sc/source/core/data/bcaslot.cxx
index da6f1b7a3232..b74fb95aaa46 100644
--- a/sc/source/core/data/bcaslot.cxx
+++ b/sc/source/core/data/bcaslot.cxx
@@ -29,6 +29,7 @@
 #include <refupdat.hxx>
 #include <table.hxx>
 #include <bulkdatahint.hxx>
+#include <columnspanset.hxx>
 
 #if DEBUG_AREA_BROADCASTER
 #include <formulacell.hxx>
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index e0ea4e04ed78..a1e44600eeac 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -101,6 +101,7 @@
 #include <tokenstringcontext.hxx>
 #include <compressedarray.hxx>
 #include <docsh.hxx>
+#include <brdcst.hxx>
 
 #include <formula/vectortoken.hxx>
 
diff --git a/sc/source/core/data/grouptokenconverter.cxx b/sc/source/core/data/grouptokenconverter.cxx
index c5e99737afab..ec96c60827cf 100644
--- a/sc/source/core/data/grouptokenconverter.cxx
+++ b/sc/source/core/data/grouptokenconverter.cxx
@@ -9,6 +9,9 @@
 
 #include <grouptokenconverter.hxx>
 #include <compiler.hxx>
+#include <document.hxx>
+#include <formulacell.hxx>
+#include <tokenarray.hxx>
 
 #include <formula/token.hxx>
 #include <formula/vectortoken.hxx>
diff --git a/sc/source/core/data/simpleformulacalc.cxx b/sc/source/core/data/simpleformulacalc.cxx
index 9882fd7a352f..75bc35a322cb 100644
--- a/sc/source/core/data/simpleformulacalc.cxx
+++ b/sc/source/core/data/simpleformulacalc.cxx
@@ -13,6 +13,7 @@
 #include <tokenarray.hxx>
 #include <interpre.hxx>
 #include <compiler.hxx>
+#include <sfx2/linkmgr.hxx>
 
 #define DISPLAY_LEN 15
 
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index 749aa4fe28e6..8362c319d2ce 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -57,6 +57,7 @@
 #include <listenercontext.hxx>
 #include <token.hxx>
 #include <compressedarray.hxx>
+#include <brdcst.hxx>
 
 #include <scitems.hxx>
 #include <editeng/boxitem.hxx>
diff --git a/sc/source/core/inc/addinlis.hxx b/sc/source/core/inc/addinlis.hxx
index 7da698456046..09bc0b85c07d 100644
--- a/sc/source/core/inc/addinlis.hxx
+++ b/sc/source/core/inc/addinlis.hxx
@@ -23,11 +23,11 @@
 #include <memory>
 #include "adiasync.hxx"
 #include <com/sun/star/sheet/XResultListener.hpp>
-#include <com/sun/star/sheet/XVolatileResult.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
 #include <cppuhelper/implbase.hxx>
-#include <rtl/ref.hxx>
-#include <list>
+
+namespace com { namespace sun { namespace star { namespace sheet { class XVolatileResult; } } } }
+namespace rtl { template <class reference_type> class Reference; }
 
 class ScDocument;
 
diff --git a/sc/source/core/inc/adiasync.hxx b/sc/source/core/inc/adiasync.hxx
index 91b65311b71e..50e3924479a1 100644
--- a/sc/source/core/inc/adiasync.hxx
+++ b/sc/source/core/inc/adiasync.hxx
@@ -22,6 +22,7 @@
 
 #include <svl/broadcast.hxx>
 #include <set>
+#include <tools/solar.h>
 
 #include <callform.hxx>
 
diff --git a/sc/source/core/inc/bcaslot.hxx b/sc/source/core/inc/bcaslot.hxx
index 2ac91fcb4438..3a2ef4d6568d 100644
--- a/sc/source/core/inc/bcaslot.hxx
+++ b/sc/source/core/inc/bcaslot.hxx
@@ -20,19 +20,19 @@
 #ifndef INCLUDED_SC_SOURCE_CORE_INC_BCASLOT_HXX
 #define INCLUDED_SC_SOURCE_CORE_INC_BCASLOT_HXX
 
-#include <functional>
 #include <memory>
 #include <map>
-#include <set>
 #include <unordered_set>
 
 #include <svl/broadcast.hxx>
+#include <svl/hint.hxx>
+#include <tools/solar.h>
 
+#include <document.hxx>
 #include <global.hxx>
-#include <brdcst.hxx>
-#include <columnspanset.hxx>
 
-class ScBroadcastArea;
+namespace sc { class ColumnSpanSet; }
+class ScHint;
 
 namespace sc {
 
diff --git a/sc/source/core/inc/cellkeytranslator.hxx b/sc/source/core/inc/cellkeytranslator.hxx
index 892d65d6f6c9..b728b1604bc6 100644
--- a/sc/source/core/inc/cellkeytranslator.hxx
+++ b/sc/source/core/inc/cellkeytranslator.hxx
@@ -20,14 +20,13 @@
 #ifndef INCLUDED_SC_SOURCE_CORE_INC_CELLKEYTRANSLATOR_HXX
 #define INCLUDED_SC_SOURCE_CORE_INC_CELLKEYTRANSLATOR_HXX
 
-#include <global.hxx>
 #include <formula/opcode.hxx>
 #include <unotools/transliterationwrapper.hxx>
 #include <vector>
 #include <memory>
 #include <unordered_map>
 
-#include <com/sun/star/lang/Locale.hpp>
+namespace com { namespace sun { namespace star { namespace lang { struct Locale; } } } }
 
 struct TransItem;
 
diff --git a/sc/source/core/inc/ddelink.hxx b/sc/source/core/inc/ddelink.hxx
index 7bcae157675d..58308b5f3e94 100644
--- a/sc/source/core/inc/ddelink.hxx
+++ b/sc/source/core/inc/ddelink.hxx
@@ -20,11 +20,12 @@
 #ifndef INCLUDED_SC_SOURCE_CORE_INC_DDELINK_HXX
 #define INCLUDED_SC_SOURCE_CORE_INC_DDELINK_HXX
 
-#include <address.hxx>
 #include <sfx2/lnkbase.hxx>
 #include <svl/broadcast.hxx>
 #include <types.hxx>
 
+namespace com { namespace sun { namespace star { namespace uno { class Any; } } } }
+
 class ScDocument;
 class ScMultipleReadHeader;
 class ScMultipleWriteHeader;
diff --git a/sc/source/core/inc/grouptokenconverter.hxx b/sc/source/core/inc/grouptokenconverter.hxx
index a51fa6337edf..cc09addfe609 100644
--- a/sc/source/core/inc/grouptokenconverter.hxx
+++ b/sc/source/core/inc/grouptokenconverter.hxx
@@ -10,13 +10,15 @@
 #ifndef INCLUDED_SC_SOURCE_CORE_INC_GROUPTOKENCONVERTER_HXX
 #define INCLUDED_SC_SOURCE_CORE_INC_GROUPTOKENCONVERTER_HXX
 
-#include <document.hxx>
-#include <formulacell.hxx>
 #include <scdllapi.h>
-#include <tokenarray.hxx>
 #include <types.hxx>
 #include <formulalogger.hxx>
 
+class ScDocument;
+class ScFormulaCell;
+class ScTokenArray;
+namespace sc { struct FormulaGroupContext; }
+
 class SC_DLLPUBLIC ScGroupTokenConverter
 {
     ScTokenArray& mrGroupTokens;
diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx
index d431dcb3c53e..211e71890b0e 100644
--- a/sc/source/core/inc/interpre.hxx
+++ b/sc/source/core/inc/interpre.hxx
@@ -20,16 +20,12 @@
 #ifndef INCLUDED_SC_SOURCE_CORE_INC_INTERPRE_HXX
 #define INCLUDED_SC_SOURCE_CORE_INC_INTERPRE_HXX
 
-#include <math.h>
 #include <rtl/math.hxx>
 #include <rtl/ustring.hxx>
 #include <unotools/textsearch.hxx>
 #include <formula/errorcodes.hxx>
 #include <formula/tokenarray.hxx>
-#include <sfx2/linkmgr.hxx>
-#include <scdll.hxx>
 #include <scdllapi.h>
-#include <interpretercontext.hxx>
 #include <types.hxx>
 #include <externalrefmgr.hxx>
 #include <calcconfig.hxx>
@@ -43,10 +39,11 @@
 #include <limits>
 #include <ostream>
 
+namespace sfx2 { class LinkManager; }
+
 class ScDocument;
 class SbxVariable;
 class ScFormulaCell;
-class SvNumberFormatter;
 class ScDBRangeBase;
 struct ScQueryParam;
 struct ScDBQueryParamBase;
@@ -54,15 +51,13 @@ struct ScQueryEntry;
 
 struct ScSingleRefData;
 struct ScComplexRefData;
+struct ScInterpreterContext;
 
-namespace formula { class FormulaToken; }
 class ScJumpMatrix;
 struct ScRefCellValue;
 
 namespace sc {
 
-struct RangeMatrix;
-struct Compare;
 struct CompareOptions;
 
 struct ParamIfsResult
diff --git a/sc/source/core/inc/jumpmatrix.hxx b/sc/source/core/inc/jumpmatrix.hxx
index c4a0b5784896..23c17a3b003f 100644
--- a/sc/source/core/inc/jumpmatrix.hxx
+++ b/sc/source/core/inc/jumpmatrix.hxx
@@ -20,14 +20,14 @@
 #ifndef INCLUDED_SC_SOURCE_CORE_INC_JUMPMATRIX_HXX
 #define INCLUDED_SC_SOURCE_CORE_INC_JUMPMATRIX_HXX
 
-#include <formula/token.hxx>
-#include <formula/errorcodes.hxx>
 #include <limits.h>
 #include <vector>
 #include <types.hxx>
 #include <address.hxx>
 #include <token.hxx>
 
+namespace formula { class FormulaToken; }
+
 typedef ::std::vector< const formula::FormulaToken*> ScTokenVec;
 
 struct ScJumpMatrixEntry
diff --git a/sc/source/core/inc/parclass.hxx b/sc/source/core/inc/parclass.hxx
index 57efd73a849f..889b2bc38947 100644
--- a/sc/source/core/inc/parclass.hxx
+++ b/sc/source/core/inc/parclass.hxx
@@ -22,7 +22,6 @@
 
 #include <formula/opcode.hxx>
 #include <formula/paramclass.hxx>
-#include <sys/types.h>
 
 /** Activate parameter classification documentation.
 
diff --git a/sc/source/core/inc/webservicelink.hxx b/sc/source/core/inc/webservicelink.hxx
index e61ebfdb4347..215a5ddb903e 100644
--- a/sc/source/core/inc/webservicelink.hxx
+++ b/sc/source/core/inc/webservicelink.hxx
@@ -10,11 +10,22 @@
 #ifndef INCLUDED_SC_SOURCE_CORE_INC_WEBSERVICE_HXX
 #define INCLUDED_SC_SOURCE_CORE_INC_WEBSERVICE_HXX
 
-#include <address.hxx>
 #include <sfx2/lnkbase.hxx>
 #include <svl/broadcast.hxx>
-#include <types.hxx>
 
+namespace com
+{
+namespace sun
+{
+namespace star
+{
+namespace uno
+{
+class Any;
+}
+}
+}
+}
 class ScDocument;
 
 class ScWebServiceLink : public ::sfx2::SvBaseLink, public SvtBroadcaster
diff --git a/sc/source/core/tool/addincol.cxx b/sc/source/core/tool/addincol.cxx
index 4709155ab719..fdf1d27dffb9 100644
--- a/sc/source/core/tool/addincol.cxx
+++ b/sc/source/core/tool/addincol.cxx
@@ -39,6 +39,7 @@
 #include <com/sun/star/sheet/XCompatibilityNames.hpp>
 #include <com/sun/star/sheet/NoConvergenceException.hpp>
 #include <com/sun/star/sheet/XAddIn.hpp>
+#include <com/sun/star/sheet/XVolatileResult.hpp>
 
 #include <addincol.hxx>
 #include <addinhelpid.hxx>
diff --git a/sc/source/core/tool/addinlis.cxx b/sc/source/core/tool/addinlis.cxx
index 2a56a6ca87f8..79eda256bb37 100644
--- a/sc/source/core/tool/addinlis.cxx
+++ b/sc/source/core/tool/addinlis.cxx
@@ -26,6 +26,8 @@
 #include <brdcst.hxx>
 #include <sc.hrc>
 
+#include <com/sun/star/sheet/XVolatileResult.hpp>
+
 using namespace com::sun::star;
 
 SC_SIMPLE_SERVICE_INFO( ScAddInListener, "ScAddInListener", "stardiv.one.sheet.AddInListener" )
diff --git a/sc/source/core/tool/cellkeytranslator.cxx b/sc/source/core/tool/cellkeytranslator.cxx
index c34276ce76a9..f2acda65ed1a 100644
--- a/sc/source/core/tool/cellkeytranslator.cxx
+++ b/sc/source/core/tool/cellkeytranslator.cxx
@@ -18,6 +18,7 @@
  */
 
 #include <memory>
+#include <global.hxx>
 #include <cellkeytranslator.hxx>
 #include <comphelper/processfactory.hxx>
 #include <i18nlangtag/mslangid.hxx>
diff --git a/sc/source/core/tool/interpr7.cxx b/sc/source/core/tool/interpr7.cxx
index 22c8cb33b3e9..b69a96504dd6 100644
--- a/sc/source/core/tool/interpr7.cxx
+++ b/sc/source/core/tool/interpr7.cxx
@@ -14,6 +14,7 @@
 #include <rtl/strbuf.hxx>
 #include <formula/errorcodes.hxx>
 #include <sfx2/bindings.hxx>
+#include <sfx2/linkmgr.hxx>
 #include <svtools/miscopt.hxx>
 #include <tools/urlobj.hxx>

More information about the Libreoffice-commits mailing list