[Libreoffice-commits] core.git: sc/IwyuFilter_sc.yaml sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Aug 31 15:42:01 UTC 2018


 sc/IwyuFilter_sc.yaml                    |    6 ++++++
 sc/source/core/opencl/formulagroupcl.cxx |    4 +---
 sc/source/core/opencl/op_addin.cxx       |    6 ------
 sc/source/core/opencl/op_array.cxx       |    6 ------
 sc/source/core/opencl/op_database.cxx    |    6 ------
 sc/source/core/opencl/op_financial.cxx   |    6 ------
 sc/source/core/opencl/op_logical.cxx     |    6 ------
 sc/source/core/opencl/op_math.cxx        |    6 ------
 sc/source/core/opencl/op_spreadsheet.cxx |    7 +------
 sc/source/core/opencl/op_statistical.cxx |    6 ------
 sc/source/core/opencl/opbase.cxx         |    1 +
 sc/source/core/opencl/opbase.hxx         |   10 +++++-----
 12 files changed, 14 insertions(+), 56 deletions(-)

New commits:
commit 347a86962bffeaf7420c390a733d2ddd1d78efeb
Author:     Gabor Kelemen <kelemeng at ubuntu.com>
AuthorDate: Sun Aug 26 16:24:35 2018 +0200
Commit:     Miklos Vajna <vmiklos at collabora.co.uk>
CommitDate: Fri Aug 31 17:41:33 2018 +0200

    tdf#42949 Fix IWYU warnings in sc/source/core/opencl/*
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here.
    
    Change-Id: I95f5ba3a4b6f72262e2fa39cb02c9d8e8f1efdd9
    Reviewed-on: https://gerrit.libreoffice.org/59743
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 0a369ba44f78..100e263949dd 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -369,3 +369,9 @@ blacklist:
     # base class has to be a complete type
     - com/sun/star/lang/XServiceInfo.hpp
     - com/sun/star/sheet/XResultListener.hpp
+    sc/source/core/opencl/formulagroupcl.cxx:
+    # Needed for implicit dtor in inverseMatrix()
+    - scmatrix.hxx
+    sc/source/core/opencl/opbase.hxx:
+    # Needed for FormulaTreeNode()
+    - formula/token.hxx
diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx
index 3abe8dbc340f..5bf0269f3978 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -9,16 +9,15 @@
 
 #include <formulagroup.hxx>
 #include <formulagroupcl.hxx>
-#include <grouptokenconverter.hxx>
 #include <document.hxx>
 #include <formulacell.hxx>
 #include <tokenarray.hxx>
 #include <compiler.hxx>
-#include <interpre.hxx>
 #include <comphelper/random.hxx>
 #include <formula/vectortoken.hxx>
 #include <scmatrix.hxx>
 #include <sal/log.hxx>
+#include <rtl/math.hxx>
 
 #include <opencl/openclwrapper.hxx>
 
@@ -127,7 +126,6 @@ static const char* const publicFunc =
 #include <vector>
 #include <map>
 #include <iostream>
-#include <sstream>
 #include <algorithm>
 
 #include <rtl/digest.h>
diff --git a/sc/source/core/opencl/op_addin.cxx b/sc/source/core/opencl/op_addin.cxx
index 8b906ae5938a..5feabef7076b 100644
--- a/sc/source/core/opencl/op_addin.cxx
+++ b/sc/source/core/opencl/op_addin.cxx
@@ -9,12 +9,6 @@
 
 #include "op_addin.hxx"
 
-#include <formulagroup.hxx>
-#include <document.hxx>
-#include <formulacell.hxx>
-#include <tokenarray.hxx>
-#include <compiler.hxx>
-#include <interpre.hxx>
 #include <formula/vectortoken.hxx>
 #include <sstream>
 
diff --git a/sc/source/core/opencl/op_array.cxx b/sc/source/core/opencl/op_array.cxx
index 45e66774a08c..58954a626646 100644
--- a/sc/source/core/opencl/op_array.cxx
+++ b/sc/source/core/opencl/op_array.cxx
@@ -9,12 +9,6 @@
 
 #include "op_array.hxx"
 
-#include <formulagroup.hxx>
-#include <document.hxx>
-#include <formulacell.hxx>
-#include <tokenarray.hxx>
-#include <compiler.hxx>
-#include <interpre.hxx>
 #include <formula/vectortoken.hxx>
 #include <sstream>
 
diff --git a/sc/source/core/opencl/op_database.cxx b/sc/source/core/opencl/op_database.cxx
index b51712382639..594b8ea8d75a 100644
--- a/sc/source/core/opencl/op_database.cxx
+++ b/sc/source/core/opencl/op_database.cxx
@@ -9,12 +9,6 @@
 
 #include "op_database.hxx"
 
-#include <formulagroup.hxx>
-#include <document.hxx>
-#include <formulacell.hxx>
-#include <tokenarray.hxx>
-#include <compiler.hxx>
-#include <interpre.hxx>
 #include <formula/vectortoken.hxx>
 #include <sstream>
 
diff --git a/sc/source/core/opencl/op_financial.cxx b/sc/source/core/opencl/op_financial.cxx
index 3d4691f26047..960175eb3709 100644
--- a/sc/source/core/opencl/op_financial.cxx
+++ b/sc/source/core/opencl/op_financial.cxx
@@ -9,12 +9,6 @@
 
 #include "op_financial.hxx"
 
-#include <formulagroup.hxx>
-#include <document.hxx>
-#include <formulacell.hxx>
-#include <tokenarray.hxx>
-#include <compiler.hxx>
-#include <interpre.hxx>
 #include <formula/vectortoken.hxx>
 #include <sstream>
 
diff --git a/sc/source/core/opencl/op_logical.cxx b/sc/source/core/opencl/op_logical.cxx
index faf1a919d7b0..d73e91747852 100644
--- a/sc/source/core/opencl/op_logical.cxx
+++ b/sc/source/core/opencl/op_logical.cxx
@@ -9,12 +9,6 @@
 
 #include "op_logical.hxx"
 
-#include <formulagroup.hxx>
-#include <document.hxx>
-#include <formulacell.hxx>
-#include <tokenarray.hxx>
-#include <compiler.hxx>
-#include <interpre.hxx>
 #include <formula/vectortoken.hxx>
 #include <sstream>
 
diff --git a/sc/source/core/opencl/op_math.cxx b/sc/source/core/opencl/op_math.cxx
index 04ca06b2e27d..62968ce75369 100644
--- a/sc/source/core/opencl/op_math.cxx
+++ b/sc/source/core/opencl/op_math.cxx
@@ -9,12 +9,6 @@
 
 #include "op_math.hxx"
 
-#include <formulagroup.hxx>
-#include <document.hxx>
-#include <formulacell.hxx>
-#include <tokenarray.hxx>
-#include <compiler.hxx>
-#include <interpre.hxx>
 #include <formula/vectortoken.hxx>
 #include "opinlinefun_math.hxx"
 #include <sstream>
diff --git a/sc/source/core/opencl/op_spreadsheet.cxx b/sc/source/core/opencl/op_spreadsheet.cxx
index be5fc318bce6..10b22b045aa6 100644
--- a/sc/source/core/opencl/op_spreadsheet.cxx
+++ b/sc/source/core/opencl/op_spreadsheet.cxx
@@ -9,12 +9,7 @@
 
 #include "op_spreadsheet.hxx"
 
-#include <formulagroup.hxx>
-#include <document.hxx>
-#include <formulacell.hxx>
-#include <tokenarray.hxx>
-#include <compiler.hxx>
-#include <interpre.hxx>
+#include <rtl/math.hxx>
 #include <formula/vectortoken.hxx>
 #include <sstream>
 
diff --git a/sc/source/core/opencl/op_statistical.cxx b/sc/source/core/opencl/op_statistical.cxx
index 524eb5ca012e..26495f90f852 100644
--- a/sc/source/core/opencl/op_statistical.cxx
+++ b/sc/source/core/opencl/op_statistical.cxx
@@ -9,12 +9,6 @@
 
 #include "op_statistical.hxx"
 
-#include <formulagroup.hxx>
-#include <document.hxx>
-#include <formulacell.hxx>
-#include <tokenarray.hxx>
-#include <compiler.hxx>
-#include <interpre.hxx>
 #include <formula/vectortoken.hxx>
 #include <sstream>
 #include "opinlinefun_statistical.cxx"
diff --git a/sc/source/core/opencl/opbase.cxx b/sc/source/core/opencl/opbase.cxx
index aa4cdf59e4fe..e4ba2a0a6d93 100644
--- a/sc/source/core/opencl/opbase.cxx
+++ b/sc/source/core/opencl/opbase.cxx
@@ -8,6 +8,7 @@
  */
 
 #include <opencl/openclwrapper.hxx>
+#include <formula/vectortoken.hxx>
 #include <sal/log.hxx>
 
 #include "opbase.hxx"
diff --git a/sc/source/core/opencl/opbase.hxx b/sc/source/core/opencl/opbase.hxx
index 7085c0a0a82e..b12879c78c16 100644
--- a/sc/source/core/opencl/opbase.hxx
+++ b/sc/source/core/opencl/opbase.hxx
@@ -10,16 +10,16 @@
 #ifndef INCLUDED_SC_SOURCE_CORE_OPENCL_OPBASE_HXX
 #define INCLUDED_SC_SOURCE_CORE_OPENCL_OPBASE_HXX
 
-#include <sal/log.hxx>
-
 #include <clew/clew.h>
-
 #include <formula/token.hxx>
-#include <formula/vectortoken.hxx>
+#include <formula/types.hxx>
 #include <memory>
 #include <set>
+#include <vector>
 
-#include <calcconfig.hxx>
+namespace formula { class DoubleVectorRefToken; }
+namespace formula { class FormulaToken; }
+struct ScCalcConfig;
 
 namespace sc { namespace opencl {
 


More information about the Libreoffice-commits mailing list