[Libreoffice-commits] online.git: loleaflet/src
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Thu Oct 18 14:10:22 UTC 2018
loleaflet/src/map/Map.js | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit c69a19ec30057be5ea9f802852ea71f5b2caa8a8
Author: Tor Lillqvist <tml at collabora.com>
AuthorDate: Thu Oct 18 16:50:12 2018 +0300
Commit: Tor Lillqvist <tml at collabora.com>
CommitDate: Thu Oct 18 17:09:03 2018 +0300
Make tapping once pop up the keyboard on a mobile device (at least an iOS one)
This fixes both the case of a normal Online instance being accessed
from a mobile device (at least Safari on an iPad), and the iOS app
being developed. The same problem was seen on both. Which isn't
surprising, as as it's the same Webkit software running the same
webpage and JavaScript.
I hope this change does not have some unintended annoying other
consequence.
Change-Id: I7ada39f1adbb9a1ac560493d926530968aa44133
diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index 63d8fa194..0991b2c7a 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -1058,8 +1058,10 @@ L.Map = L.Evented.extend({
// For touch devices, to pop-up the keyboard, it is required to call
// .focus() method on hidden input within actual 'click' event here
- // Calling from some other place with no real 'click' event doesn't work
- if (type === 'click') {
+ // Calling from some other place with no real 'click' event doesn't work.
+ // (tml: For me, for this to work with a mobile device, we need to
+ // accept 'mousedown', too. At least with an an iPad, iOS 12.)
+ if (type === 'click' || type === 'mousedown') {
if (this._permission === 'edit') {
this.focus();
}
More information about the Libreoffice-commits
mailing list