[Libreoffice-commits] online.git: loleaflet/src
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Wed Oct 24 08:49:37 UTC 2018
loleaflet/src/map/Map.js | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
New commits:
commit cf545b0b2f4e0646ba48f6313239ce465c50f6f9
Author: Tor Lillqvist <tml at collabora.com>
AuthorDate: Wed Oct 24 11:38:54 2018 +0300
Commit: Tor Lillqvist <tml at collabora.com>
CommitDate: Wed Oct 24 11:40:49 2018 +0300
Revert "Make tapping once pop up the keyboard on a mobile device (at least an iOS one)"
Nah, that fixes one thing but breaks another. After the change that is
reverted, the on-screen keyboard pops up too often, also when you just
want to pan around in the document.
Let's see how hard it will be to make the on-screen keyboard pop up
only when actually wanted (after a single quick tap, and after
selecting a word with a double-tap, IIUC) and never otherwise.
This reverts commit c69a19ec30057be5ea9f802852ea71f5b2caa8a8.
diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index 0991b2c7a..63d8fa194 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -1058,10 +1058,8 @@ L.Map = L.Evented.extend({
// For touch devices, to pop-up the keyboard, it is required to call
// .focus() method on hidden input within actual 'click' event here
- // Calling from some other place with no real 'click' event doesn't work.
- // (tml: For me, for this to work with a mobile device, we need to
- // accept 'mousedown', too. At least with an an iPad, iOS 12.)
- if (type === 'click' || type === 'mousedown') {
+ // Calling from some other place with no real 'click' event doesn't work
+ if (type === 'click') {
if (this._permission === 'edit') {
this.focus();
}
More information about the Libreoffice-commits
mailing list