[Libreoffice-commits] core.git: filter/source

[Libreoffice Gerrit user]

 filter/source/svg/svgfilter.cxx |    6 ------
 1 file changed, 6 deletions(-)

New commits:
commit 630f506ff2e505b093ab54a5d4394adcd7dd0be2
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sun Oct 21 12:04:15 2018 +0200
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Sun Oct 21 15:25:13 2018 +0200

    tdf#120703 (PVS): redundant nullptr check
    
    V668 There is no sense in testing the 'aNewSdrGrafObj' pointer against null, as
         the memory was allocated using the 'new' operator. The exception will be
         generated in the case of memory allocation error.
    
    Change-Id: I78159c7bd19bacea7120abc8015b866e6179c719
    Reviewed-on: https://gerrit.libreoffice.org/62128
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/filter/source/svg/svgfilter.cxx b/filter/source/svg/svgfilter.cxx
index b638794c8385..4f7b8982f1ae 100644
--- a/filter/source/svg/svgfilter.cxx
+++ b/filter/source/svg/svgfilter.cxx
@@ -260,12 +260,6 @@ sal_Bool SAL_CALL SVGFilter::filter( const Sequence< PropertyValue >& rDescripto
                     new SdrGrafObj(
                         pTargetSdrPage->getSdrModelFromSdrPage(),
                         aGraphic));
-
-                if (!aNewSdrGrafObj)
-                {
-                    // could not create GraphicObject
-                    break;
-                }
             }
 
             // Evtl. adapt the GraphicPrefSize to target-MapMode of target-Model