[Libreoffice-commits] core.git: filter/source
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Sun Oct 21 13:48:20 UTC 2018
filter/source/graphicfilter/icgm/cgm.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 63e85b852b9507f7a034b930a20678ee88c2fd0b
Author: Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sun Oct 21 14:04:18 2018 +0200
Commit: Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Sun Oct 21 15:47:56 2018 +0200
tdf#120703 (PVS): redundant nullptr check
V668 There is no sense in testing the 'pCGM' pointer against null, as the
memory was allocated using the 'new' operator. The exception will be
generated in the case of memory allocation error.
Change-Id: Ib07d1ceaf01f657e67572c0f5bcd6aae497d2d07
Reviewed-on: https://gerrit.libreoffice.org/62132
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>
diff --git a/filter/source/graphicfilter/icgm/cgm.cxx b/filter/source/graphicfilter/icgm/cgm.cxx
index e1d686c5e8c3..ba775e98fed8 100644
--- a/filter/source/graphicfilter/icgm/cgm.cxx
+++ b/filter/source/graphicfilter/icgm/cgm.cxx
@@ -695,7 +695,7 @@ ImportCGM(SvStream& rIn, uno::Reference< frame::XModel > const & rXModel, css::u
try
{
std::unique_ptr<CGM> pCGM(new CGM(rXModel));
- if (pCGM && pCGM->IsValid())
+ if (pCGM->IsValid())
{
rIn.SetEndian(SvStreamEndian::BIG);
sal_uInt64 const nInSize = rIn.remainingSize();
More information about the Libreoffice-commits
mailing list