[Libreoffice-commits] online.git: loleaflet/src

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Oct 25 08:06:49 UTC 2018


 loleaflet/src/map/handler/Map.Keyboard.js |    6 ++++++
 1 file changed, 6 insertions(+)

New commits:
commit 1e97cfc2d2a8ee3e296ddfb7a331466bede4a575
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Wed Oct 24 18:37:17 2018 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Thu Oct 25 10:06:30 2018 +0200

    tdf#120438: Don't handle a lone "alt" modifier in any special way
    
    It is likely a Mac browser client simply accessing a "special
    character" on their keyboard. (Or an iOS browser client using a
    physical keyboard.) Like alt+8 to get '[' on a Swedish/Finnish Apple
    keyboard, or alt+shift+2 to get '€' on a US English Apple keyboard.
    
    Change-Id: I94b49d64db87324ff2a5cd5f50226d3c537b68e6
    Reviewed-on: https://gerrit.libreoffice.org/62315
    Reviewed-by: Tor Lillqvist <tml at collabora.com>
    Tested-by: Tor Lillqvist <tml at collabora.com>

diff --git a/loleaflet/src/map/handler/Map.Keyboard.js b/loleaflet/src/map/handler/Map.Keyboard.js
index d6466e95c..607e3283e 100644
--- a/loleaflet/src/map/handler/Map.Keyboard.js
+++ b/loleaflet/src/map/handler/Map.Keyboard.js
@@ -302,6 +302,12 @@ L.Map.Keyboard = L.Handler.extend({
 			inputEle.value = '';
 		}
 
+		if (this.modifier == this.keyModifier.alt || this.modifier == this.keyModifier.shift + this.keyModifier.alt) {
+			// Presumably a Mac or iOS client accessing a "special character". Just ignore the alt modifier.
+			this.modifier -= alt;
+			alt = 0;
+		}
+
 		var unoKeyCode = this._toUNOKeyCode(keyCode);
 
 		if (this.modifier) {


More information about the Libreoffice-commits mailing list